Skip to content

fix: prevent azd down from deleting pre-existing resource groups #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jongio wants to merge 25 commits into
base: main
Choose a base branch
from
Open

fix: prevent azd down from deleting pre-existing resource groups #7603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a78dbb5
fix: prevent azd down from deleting pre-existing resource groups (#47…
jongio Apr 9, 2026
56ffeb8
fix: harden azd-down RG safety with MQ wave 1 fixes
jongio Apr 9, 2026
1dc6bd4
refactor: MQ wave 2 fixes — export lock constants, add coverage tests
jongio Apr 9, 2026
36ab35f
style: gofmt alignment in bicep_destroy.go
jongio Apr 9, 2026
d401500
fix: preflight — wg.Go, remove dead code, add armlocks to cspell
jongio Apr 9, 2026
ff7008c
fix: preserve deployment stacks delete path in azd down
jongio Apr 9, 2026
b9bfd00
test: improve coverage for RG safety destroy orchestration
jongio Apr 9, 2026
47814c9
refactor: extract purge helpers, fix data race in test, add security …
jongio Apr 9, 2026
eace19e
fix: cancel preserves state, stacks checked before zero-resources
jongio Apr 9, 2026
874f0b5
fix: restore purge error propagation, filter extension resources, can…
jongio Apr 9, 2026
01bde00
fix: collect purge targets before RG deletion, remove invalid $expand…
jongio Apr 9, 2026
1638108
fix: attempt purge even after partial RG deletion failure
jongio Apr 9, 2026
6d4f683
test: add partial-delete purge regression test
jongio Apr 9, 2026
4bb8888
chore: add 'reprovisioning' to cspell dictionary
jongio Apr 9, 2026
7e4452a
fix: --force now runs Tier 1 to protect external RGs + integration tests
jongio Apr 9, 2026
b8c9531
quality: apply max-quality wave 1-3 fixes
jongio Apr 10, 2026
58874e3
refactor: replace to.Ptr() with new() per Go 1.26 convention
jongio Apr 10, 2026
d2922d5
feat: add bicep snapshot as primary RG classification source
jongio Apr 11, 2026
f800aed
refactor: extract runTier4Vetoes, fix MQ quality findings
jongio Apr 11, 2026
aa6e4ff
test: fill coverage gaps for RG classification and snapshot prediction
jongio Apr 11, 2026
153ca3b
refactor: MQ2 quality fixes — extract mock helper, remove shadows, fi…
jongio Apr 11, 2026
ac8c66d
fix: collect maps.Keys iterator for log output
jongio Apr 13, 2026
2682c25
Remove Tiers 1-3 from resource group classifier, keep snapshot + Tier 4
jongio Apr 13, 2026
3e77fe1
docs: update architecture doc and classifier comments for snapshot-on…
jongio Apr 13, 2026
bb6b1df
Remove dead TagKeyProvisionParamHash constant
jongio Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,4 @@ cli/azd/extensions/microsoft.azd.concurx/concurx.exe
cli/azd/extensions/azure.appservice/azureappservice
cli/azd/extensions/azure.appservice/azureappservice.exe
.squad/
cli/azd/coverage-*
15 changes: 15 additions & 0 deletions .vscode/cspell.misc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,21 @@ overrides:
- Entra
- CODEOWNERS
- weikanglim
- filename: ./docs/azd-down-resource-group-safety/**
words:
- azapi
- TOCTOU
- goroutines
- Footgun
- Errorf
- vhvb
- nicklhw
- Breza
- wbreza
- armlocks
- hemarina
- underspecified
- Stringly
- filename: ./README.md
words:
- VSIX
Expand Down
1 change: 1 addition & 0 deletions cli/azd/.vscode/cspell-azd-dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ armappplatform
armcognitiveservices
armcosmos
armdeploymentstacks
armlocks
armmachinelearning
armmsi
armoperationalinsights
Expand Down
2 changes: 2 additions & 0 deletions cli/azd/.vscode/cspell.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ words:
- cooldown
- customtype
- devcontainers
- diagnosticsettings
- errgroup
- errorhandler
- extendee
Expand Down Expand Up @@ -56,6 +57,7 @@ words:
- structpb
- syncmap
- syscall
- reprovisioning
- tsx
- Retryable
- runcontext
Expand Down
1 change: 1 addition & 0 deletions cli/azd/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ require (
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/operationalinsights/armoperationalinsights/v2 v2.0.2
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resourcegraph/armresourcegraph v0.9.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks v1.0.1
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armlocks v1.2.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.2.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armsubscriptions v1.3.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql/v2 v2.0.0-beta.7
Expand Down
2 changes: 2 additions & 0 deletions cli/azd/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resourcegraph/armresourceg
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resourcegraph/armresourcegraph v0.9.0/go.mod h1:wVEOJfGTj0oPAUGA1JuRAvz/lxXQsWW16axmHPP47Bk=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks v1.0.1 h1:bcgO/crpp7wqI0Froi/I4C2fme7Vk/WLusbV399Do8I=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks v1.0.1/go.mod h1:kvfPmsE8gpOwwC1qrO1FeyBDDNfnwBN5UU3MPNiWW7I=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armlocks v1.2.0 h1:CMp8GwmUfS/Stg5KBgduD8rPIk9GNj1HMaID/gUAJYg=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armlocks v1.2.0/go.mod h1:GE1wqa9Ny9eZ8wHtHqbCE7mMsFfVbdEY0itmzYV8JEg=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.2.0 h1:Dd+RhdJn0OTtVGaeDLZpcumkIVCtA/3/Fo42+eoYvVM=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.2.0/go.mod h1:5kakwfW5CjC9KK+Q4wjXAg+ShuIm2mBMua0ZFj2C8PE=
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armsubscriptions v1.3.0 h1:wxQx2Bt4xzPIKvW59WQf1tJNx/ZZKPfN+EhPX3Z6CYY=
Expand Down
8 changes: 8 additions & 0 deletions cli/azd/pkg/azapi/deployments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,14 @@ type DeploymentService interface {
options map[string]any,
progress *async.Progress[DeleteDeploymentProgress],
) error
// VoidSubscriptionDeploymentState deploys an empty template to void the deployment state
// without deleting any resource groups. Used after classification-aware deletion.
VoidSubscriptionDeploymentState(
ctx context.Context,
subscriptionId string,
deploymentName string,
options map[string]any,
) error
}

type DeleteResourceState string
Expand Down
Loading
Loading