fix: clear ENABLE_VIRTUAL_TERMINAL_INPUT on Windows to fix PowerShell arrow keys#7646
Closed
fix: clear ENABLE_VIRTUAL_TERMINAL_INPUT on Windows to fix PowerShell arrow keys#7646
Conversation
… arrow keys (#7641) On Windows/PowerShell, the ENABLE_VIRTUAL_TERMINAL_INPUT console flag causes arrow keys to be delivered as ANSI escape sequences instead of native virtual key codes. The survey library's Windows ReadRune only handles native VK codes, so the escape sequence fragments leak through as individual runes. This fix clears the VTI flag after SetTermMode() during input reading. RestoreTermMode() restores the original console state (including VTI if it was originally set). Fixes #7641 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vhvb1989
force-pushed
the
fix/pwsh-arrow-keys-clear-vti
branch
from
a14a299 to
09a0768
Compare
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
jongio
approved these changes
Apr 10, 2026
Member
jongio
left a comment
jongio
left a comment
There was a problem hiding this comment.
This is the right approach - fixing at the console flag level instead of compensating downstream with an escape sequence parser.
Verified the Win32 API usage: 0x0200 is correct for ENABLE_VIRTUAL_TERMINAL_INPUT, the bit-clear with &^ is right, and placing the call after SetTermMode() means RestoreTermMode() correctly restores VTI from its saved original mode. The graceful degradation (log warning on failure, fall back to pre-fix behavior) is a good choice.
Two items before this is merge-ready:
-
CI failure: The Azure DevOps "BuildCLI Windows" job failed. GitHub Actions checks (Windows lint, cross-compile) all pass, so this looks like a test/runtime issue rather than a compilation problem. Worth investigating - could be an unrelated flake or could surface a real interaction.
-
Test coverage: Consider adding a test seam around the console mode calls so you can verify the VTI flag gets cleared (and only on Windows). The function is hard to test directly against real console handles, but injecting the get/set calls would make the mode transition testable and help prevent regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative approach to #7642
This is a draft PR illustrating an alternative fix for #7641 — clearing the
ENABLE_VIRTUAL_TERMINAL_INPUTconsole flag on Windows instead of adding an escape sequence parser.Why
The root cause is that PowerShell enables
ENABLE_VIRTUAL_TERMINAL_INPUT(0x0200) on the console input handle. This makes Windows translate arrow key presses into ANSI escape sequences (ESC [ A) instead of delivering native virtual key codes (VK_UP). The survey library's WindowsReadRune()only handles native VK codes, so the escape fragments leak through as individual runes.How
After
survey.SetTermMode()(which saves the original console state), we additionally clear the VTI flag. The existingRestoreTermMode()restores the original state, re-enabling VTI if it was originally set.Changes
pkg/ux/internal/console_windows.goENABLE_VIRTUAL_TERMINAL_INPUTvia Win32 APIpkg/ux/internal/console_other.gopkg/ux/internal/input.goSetTermMode()Comparison with #7642
[A–[Dfilter false positive on Linux/macOSSee the detailed analysis comment on #7642.
Fixes #7641