fix changelog skill to include azdext version.go#7656
Open
rajeshkamal5050 wants to merge 1 commit intomainfrom
Open
fix changelog skill to include azdext version.go#7656rajeshkamal5050 wants to merge 1 commit intomainfrom
rajeshkamal5050 wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rajeshkamal5050
requested review from
danieljurek,
jongio,
tg-msft,
vhvb1989 and
wbreza
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the changelog-generation workflow documentation so core release version bumps also include cli/azd/pkg/azdext/version.go, preventing mismatches between cli/version.txt and the azdext SDK version constant.
Changes:
- Extend the core “files to update” list to include
cli/azd/pkg/azdext/version.go. - Clarify core version bump instructions to update the azdext
Versionconstant alongsidecli/version.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/skills/changelog-generation/SKILL.md | Updates the core release instructions to include bumping azdext/version.go. |
| .github/skills/changelog-generation/references/scope-rules.md | Adds azdext/version.go to the core version files list and derivation steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog skill didn't know about
cli/azd/pkg/azdext/version.go(added in #7403). Core releases need to bump theVersionconstant there too.Found this when PR #7639 bumped
cli/version.txtto 1.23.15 but leftversion.goat 1.24.0-beta.1.Updated SKILL.md and scope-rules.md to include
version.goin the core release file list.Fixes #7638