fix: Remove hasattr check for every invocation#1834
Merged
gavin-aguiar merged 6 commits intodevfrom Mar 13, 2026
Merged
Conversation
hallvictoria
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has three key optimizations in the dispatcher:
Eliminated Repeated Attribute Checks (hasattr):
Change: Introduced a global flag _library_worker_has_cv that is set once when the worker library is loaded.
Impact: get_current_invocation_id runs on every log message. Previously, it called hasattr(_library_worker, 'invocation_id_cv') thousands of times during startup. This is now a fast boolean check.
Lock-Free Fast Path for Invocation ID:
Change: Reordered get_current_invocation_id to check the ContextVar before checking the thread-local registry.
Impact: The thread registry requires acquiring a threading.Lock. By checking the context variable first, we avoid lock acquisition overhead and contention for the vast majority of log calls in modern Python versions.
Cached Protobuf Constants in Hot Path:
Change: Created module-level constants for RpcLog levels (e.g., _LOG_LEVEL_INFO) and categories (_LOG_CATEGORY_SYSTEM).
Impact: The on_logging method previously performed expensive attribute lookups (e.g., protos.RpcLog.Information) and function calls (.Value('System')) for every log record. These are now instant constant lookups.
Fixes #
Pull Request Checklist
Host-Worker Contract
Worker Execution Logic
If yes, please answer the following:
Python Version Coverage
Programming Model Compatibility (for Python 3.13+)