Open
Conversation
norakoiralamsft
requested review from
a team,
D1v38om83r and
nkuchta
as code owners
jscalev
previously approved these changes
Mar 30, 2026
alsanmsft
reviewed
Apr 14, 2026
Comment on lines
+34
to
+36
| if cryptImported == False: | ||
| try: | ||
| from passlib.hash import sha512_crypt |
There was a problem hiding this comment.
question for my understanding: why do we not try to import passlib right away after crypt fails? why is it our second fallback, not our first? what benefits does legacycrypt have?
| return crypt.crypt(password, salt) | ||
|
|
||
| if cryptImported: | ||
| return crypt(password, salt) |
There was a problem hiding this comment.
maybe a dumb question, but is crypt() a different or the same algorithm as sha512_crypt()? why do we prefer to use one over the other?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed to add fallbacks for importing the cypt library with was deprecated in python 3.11, takes a similar approach as to Linux Agent, first trying to import crypt (which includes crypt + crypt_r), legacycrypt, and finally passlib.
This was chosen over the crypt_fallback that was introduced in this PR because we want to continue supporting older distros that may not have cyptes available, and Canocial raised concerns about the crypt_r lib as well, and have ensured that passlib will be available on Ubuntu.