Upgrade minimatch in spelling package-lock.json#7055
Open
mohamed-zaki-coding wants to merge 1 commit intoAzure:feature/websocket_speechfrom
Open
Upgrade minimatch in spelling package-lock.json#7055mohamed-zaki-coding wants to merge 1 commit intoAzure:feature/websocket_speechfrom
mohamed-zaki-coding wants to merge 1 commit intoAzure:feature/websocket_speechfrom
Conversation
mohamed-zaki-coding
requested review from
benbp,
danieljurek and
weshaggard
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @mohamed-zaki-coding! We will review the pull request and get back to you soon. |
mohamed-zaki-coding
changed the title
mohamed-zaki-coding
requested review from
LarryOsterman,
RickWinter,
ahmadmsft,
anilba06,
antkmsft,
gkostal and
vhvb1989
as code owners
mohamed-zaki-coding
force-pushed
the
fix/upgrade-minimatch-package
branch
from
48c5534 to
185a8bf
Compare
mohamed-zaki-coding
force-pushed
the
fix/upgrade-minimatch-package
branch
2 times, most recently
from
79565b5 to
b33182a
Compare
danieljurek
approved these changes
Apr 10, 2026
Member
danieljurek
left a comment
danieljurek
left a comment
There was a problem hiding this comment.
This PR does get rid of vulnerabilities and passes npm audit but you'll need to get permission here to merge the PR: https://eng.ms/docs/products/azure-developer-experience/onboard/access#request-access-to-azure-rest-api-and-sdk-repositories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the minimatch dependency in
eng/common/spelling/package-lock.jsonto fix CVE-2026-27903 and CVE-2026-27904.Changes
eng/common/spelling/package-lock.jsonto resolve vulnerable minimatch versions.Target Branch
This PR targets
feature/websocket_speech(the branch the Carbon submodule tracks) rather thanmainto avoid pulling in unrelated feature branch divergence.