[AutoPR azure-security-keyvault-certificates]-generated-from-SDK Generation - Java-5984840#48346
Conversation
…s/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '35275d315efee7fa79b6661c29cb3f1c05e86b76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5984840 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Hi @azure-java-sdk /@azure-sdk-write-keyvault This PR was auto-generated from spec PR Azure/azure-rest-api-specs#41061 which added These fields were added in API version 2025-06-01-preview and are available in 2025-07-01 (stable). The code generation succeeded, but tests are failing because the test recordings don't include these API versions. Could you help re-record the tests against a live Key Vault instance? Thanks! |
There was a problem hiding this comment.
Pull request overview
This is an auto-generated SDK update for azure-security-keyvault-certificates, regenerated from the Key Vault API spec at commit 35275d315efee7fa79b6661c29cb3f1c05e86b76 (API version 2025-07-01 stable). The primary functional addition is support for two new SAN (Subject Alternative Names) fields: uniformResourceIdentifiers (URIs) and ipAddresses.
Changes:
- Added
uniformResourceIdentifiersandipAddressesfields (with getters, setters, and JSON serialization/deserialization) toSubjectAlternativeNames - Updated Javadoc across
CertificateClientImplto document the new SAN fields; also removed the unnecessaryAcceptheader from thepurgeDeletedCertificateoperation (which returns 204 No Content) - Updated
tsp-location.yamlto the new commit SHA andCHANGELOG.mdto reflect the new features
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tsp-location.yaml |
Updated commit SHA; removed cleanup: true and trailing slash from additionalDirectories — inconsistent with other Key Vault packages |
SubjectAlternativeNames.java |
Added uniformResourceIdentifiers and ipAddresses fields with getters, setters, and JSON serialization/deserialization |
CertificateClientImpl.java |
Updated Javadoc for new SAN fields; removed Accept header from the 204 purgeDeletedCertificate operation |
CHANGELOG.md |
Added 4.9.0-beta.1 release date and new feature entries; removed existing bug fix entry for issue #47801 |
| * `setIpAddresses(java.util.List)` was added | ||
| * `getUniformResourceIdentifiers()` was added | ||
| * `getIpAddresses()` was added | ||
|
|
There was a problem hiding this comment.
The original 4.9.0-beta.1 unreleased section contained a "Bugs Fixed" entry for HttpResponseException.getResponse() calls potentially causing a NullPointerException (referenced as issue #47801). This entry has been removed from the CHANGELOG in this PR, and there is no indication that the fix was moved to a different release entry or that it was determined to be incorrect/duplicate. If the bug fix was previously included in 4.9.0-beta.1, it should remain in the changelog for that version to properly track changes for users upgrading.
| ### Bugs Fixed | |
| - Fixed a potential `NullPointerException` when calling `HttpResponseException.getResponse()` in certain failure scenarios. (#47801) |
| directory: specification/keyvault/Security.KeyVault.Certificates | ||
| commit: 396ab529763b7195ab089f58e2eefb011e1b290d | ||
| commit: 35275d315efee7fa79b6661c29cb3f1c05e86b76 | ||
| repo: Azure/azure-rest-api-specs |
There was a problem hiding this comment.
The cleanup: true field has been removed from this file. All other Key Vault packages (azure-security-keyvault-keys, azure-security-keyvault-secrets, and azure-security-keyvault-administration) include cleanup: true in their tsp-location.yaml. Removing this flag may affect the codegen behavior for this package inconsistently with its sibling packages.
For example, sdk/keyvault/azure-security-keyvault-keys/tsp-location.yaml line 4 has cleanup: true, and so does sdk/keyvault/azure-security-keyvault-secrets/tsp-location.yaml line 4.
If this removal is intentional due to a change in the new API version's codegen requirements, it should be explicitly documented.
| repo: Azure/azure-rest-api-specs | |
| repo: Azure/azure-rest-api-specs | |
| cleanup: true |
| additionalDirectories: | ||
| - specification/keyvault/Security.KeyVault.Common/ | ||
| additionalDirectories: | ||
| - specification/keyvault/Security.KeyVault.Common |
There was a problem hiding this comment.
The path for Security.KeyVault.Common is missing the trailing slash. All other Key Vault packages use specification/keyvault/Security.KeyVault.Common/ (with trailing slash) in their additionalDirectories. For example, sdk/keyvault/azure-security-keyvault-keys/tsp-location.yaml uses - specification/keyvault/Security.KeyVault.Common/. This inconsistency may affect how the TypeSpec emitter resolves the directory during code generation.
| - specification/keyvault/Security.KeyVault.Common | |
| - specification/keyvault/Security.KeyVault.Common/ |
…rtificates-5984840' into pr-48346-check
…ed dep failures When generate_from_source_pom.py walks up the parent POM chain in add_source_projects, it was adding all parent POMs to the from-source reactor including stable ones (dep_version == current_version) such as azure-cosmos-spark_3 and azure-cosmos-spark_3-5. Stable parent POMs are already published to the artifact feed. When Maven includes them as reactor modules (packaging=pom), it validates their declared test-scope dependencies. azure-cosmos-spark_3 has a direct test-scope dependency on azure-cosmos-test:1.0.0-beta.18 (unreleased), causing keyvault from-source builds to fail with: 'Could not find artifact com.azure:azure-cosmos-test:jar:1.0.0-beta.18' Maven does not need these parent POMs in the reactor -- it resolves them via relativePath from the local filesystem for configuration inheritance. Only parent POMs that are not yet released (dep != current) OR are in parent_pom_identifiers need to be in the from-source reactor. This fixes the ubuntu2404_125_FromSource_SkipRebuild_Verify CI failure introduced by the spark 4.45.0 release (Azure#48413) which bumped azure-cosmos-test to current version 1.0.0-beta.18 (unreleased).
The previous fix removed stable parent POMs (azure-cosmos-spark_3, azure-cosmos-spark_3-5) from the from-source reactor. However, modules that remain in the reactor (azure-cosmos-spark_3-5_2-12) still inherit test dependencies from those stable parent POMs via the relativePath parent chain. Specifically: azure-cosmos-spark_3-5_2-12 -> azure-cosmos-spark_3-5 -> azure-cosmos-spark_3 azure-cosmos-spark_3 declares azure-cosmos-test:1.0.0-beta.18 (unreleased) azure-cosmos-spark_3-5_2-12 inherits this as a test-scope dependency Without azure-cosmos-test in the reactor, Maven fails trying to download the unreleased artifact from the feed. Fix resolve_project_dependencies to walk the FULL parent POM chain (not just one level deep) when collecting dependencies. This ensures that azure-cosmos-test:1.0.0-beta.18 is discovered as an inherited dependency of azure-cosmos-spark_3-5_2-12 and added to the from-source reactor, where it can be built from source instead of downloaded from the feed.
…NGELOG Per Azure SDK conventions, the top CHANGELOG entry should use (Unreleased) until a release is cut. Also restores the Breaking Changes and Other Changes section headers that were missing.
rohitsinghal4u
requested review from
benbp,
raych1 and
weshaggard
as code owners
Configurations: 'specification/keyvault/Security.KeyVault.Certificates/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '35275d315efee7fa79b6661c29cb3f1c05e86b76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5984840 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.