Skip to content

[AutoPR azure-resourcemanager-containerservice-generated]-generated-from-SDK Generation - Java-6020376#48439

Open
azure-sdk wants to merge 2 commits intoAzure:mainfrom
azure-sdk:sdkauto/azure-resourcemanager-containerservice-generated-6020376
Open

[AutoPR azure-resourcemanager-containerservice-generated]-generated-from-SDK Generation - Java-6020376#48439
azure-sdk wants to merge 2 commits intoAzure:mainfrom
azure-sdk:sdkauto/azure-resourcemanager-containerservice-generated-6020376

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Mar 17, 2026

Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/aks/tspconfig.yaml', API Version: 2026-01-01, SDK Release Type: stable, and CommitSHA: '94b9d66abfea1941f60b7671174f668d2e6a7d84' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6020376 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=7742a2ce-4418-f111-8341-000d3a376cbb Submitted by: fumingzhang@microsoft.com

Release Plan Details

…osoft.ContainerService/aks/tspconfig.yaml', API Version: 2026-01-01, SDK Release Type: stable, and CommitSHA: '94b9d66abfea1941f60b7671174f668d2e6a7d84' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6020376 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@FumingZhang FumingZhang marked this pull request as ready for review March 20, 2026 00:33
Copilot AI review requested due to automatic review settings March 20, 2026 00:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new generated Azure Resource Manager Container Service management module (api-version 2026-01-01) and wires it into repo versioning/release metadata.

Changes:

  • Introduces new azure-resourcemanager-containerservice-generated Maven module with initial dependencies and metadata.
  • Adds initial package docs (README.md) and release notes (CHANGELOG.md) for version 1.0.0.
  • Registers the new artifact in eng/versioning/version_client.txt.

Reviewed changes

Copilot reviewed 4 out of 619 changed files in this pull request and generated 4 comments.

File Description
sdk/containerservice/azure-resourcemanager-containerservice-generated/pom.xml New Maven module definition, dependencies, and publishing metadata.
sdk/containerservice/azure-resourcemanager-containerservice-generated/README.md New package README with setup and authentication guidance.
sdk/containerservice/azure-resourcemanager-containerservice-generated/CHANGELOG.md Initial changelog entry for the first release.
eng/versioning/version_client.txt Adds the new artifact to version tracking.

<licenses>
<license>
<name>The MIT License (MIT)</name>
<url>http://opensource.org/licenses/MIT</url>
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License URLs should use HTTPS to avoid mixed-content and to align with common Maven publishing metadata conventions. Consider changing this to https://opensource.org/licenses/MIT.

Suggested change
<url>http://opensource.org/licenses/MIT</url>
<url>https://opensource.org/licenses/MIT</url>

Copilot uses AI. Check for mistakes.
Comment on lines +34 to +35
<connection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</connection>
<developerConnection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</developerConnection>
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using SSH-style SCM connections (git@github.com:...) can break tooling in environments without SSH keys (release/publishing automation, consumers running SCM plugins). Prefer HTTPS SCM coordinates (e.g., scm:git:https://github.com/Azure/azure-sdk-for-java.git) for broader compatibility.

Suggested change
<connection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</connection>
<developerConnection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</developerConnection>
<connection>scm:git:https://github.com/Azure/azure-sdk-for-java.git</connection>
<developerConnection>scm:git:https://github.com/Azure/azure-sdk-for-java.git</developerConnection>

Copilot uses AI. Check for mistakes.
Comment on lines +44 to +48
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<jacoco.min.linecoverage>0</jacoco.min.linecoverage>
<jacoco.min.branchcoverage>0</jacoco.min.branchcoverage>
</properties>
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting JaCoCo minimum coverage to 0 disables coverage enforcement for this module. If this artifact is intended to ship as a stable library, add at least basic unit tests (and/or smoke tests, if that’s the repo standard for mgmt modules) and raise these thresholds to a non-zero baseline so regressions are caught.

Copilot generated this review using guidance from repository custom instructions.

## 1.0.0 (2026-03-17)

- Azure Resource Manager Container Service client library for Java. This package contains Microsoft Azure SDK for Container Service Management SDK. The Container Service Client. Package api-version 2026-01-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog section formatting is inconsistent: a bullet appears before the ### Features Added heading. To match typical Azure SDK changelog structure, place headings before their bullet lists, and consider making the long package description a paragraph (non-bulleted) under the version heading.

Suggested change
- Azure Resource Manager Container Service client library for Java. This package contains Microsoft Azure SDK for Container Service Management SDK. The Container Service Client. Package api-version 2026-01-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
Azure Resource Manager Container Service client library for Java. This package contains Microsoft Azure SDK for Container Service Management SDK. The Container Service Client. Package api-version 2026-01-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).

Copilot uses AI. Check for mistakes.
@weidongxu-microsoft
Copy link
Member

We will need some manual update on tspconfig and the repo for the 1st release from TypeSpec. Please wait a few days while SDK dev work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants