Skip to content

Fix parent POM dependency resolution in From Source generator #48482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 1 commit into from
Mar 20, 2026
+3 −5
Merged

Fix parent POM dependency resolution in From Source generator #48482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions eng/scripts/generate_from_source_pom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,11 +311,9 @@ def resolve_project_dependencies(pom_identifier: str, dependency_modules: Set[st
# These are added since From Source the parent POMs are also built.
if project.parent_pom is not None and project.parent_pom in projects:
parent_project = projects[project.parent_pom]
for dependency in parent_project.dependencies:
# Only continue if the parent's dependencies haven't already been resolved.
if not dependency in dependency_modules:
dependency_modules.add(dependency)
dependency_modules = resolve_project_dependencies(dependency, dependency_modules, projects)
if not parent_project.identifier in dependency_modules:
dependency_modules.add(parent_project.identifier)
dependency_modules = resolve_project_dependencies(parent_project.identifier, dependency_modules, projects)

return dependency_modules

Expand Down
Loading