Eval samples test (3): Add inline-data evaluation samples#44950
Merged
Eval samples test (3): Add inline-data evaluation samples#44950
Conversation
7d31678 to
7626e53
Compare
- Update sample_evaluations_graders.py to use inline data instead of file upload - Update sample_evaluations_ai_assisted.py to use inline data instead of file upload - Update sample_evaluation_cluster_insight.py to use inline data instead of file upload - Add samples/evaluations/README.md as an index for all evaluation samples - Update test_samples_evaluations.py to test the updated samples - Remove unnecessary inline-data sample duplicates - Update assets.json with new recordings
7626e53 to
883fd24
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies three existing evaluation samples to use inline data instead of file uploads to Azure Blob Storage, enabling them to be included in automated test coverage with test proxy playback.
Changes:
- Converted
sample_evaluations_graders.py,sample_evaluations_ai_assisted.py, andsample_evaluation_cluster_insight.pyto use inline data instead of dataset file uploads - Added these three samples to the test suite (increasing test coverage from 25 to 28 samples)
- Added comprehensive README.md documentation for the evaluations samples folder
- Updated test recordings in assets.json
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test_samples_evaluations.py | Updated docstring to reflect new sample count (25→28) and added three samples to test list; removed these samples from the excluded list |
| sample_evaluations_graders.py | Removed dataset upload code and DatasetVersion import; converted to use SourceFileContent with inline data; fixed "and and" typo in description |
| sample_evaluations_ai_assisted.py | Removed dataset upload code and DatasetVersion import; converted to use SourceFileContent with inline data; fixed "and and" typo in description |
| sample_evaluation_cluster_insight.py | Removed dataset upload, temp file creation, and unused imports (json, tempfile); converted to use SourceFileContent with inline data |
| README.md | Added comprehensive documentation for all evaluation samples with categorized tables and links |
| assets.json | Updated test recording tag to include new recordings |
howieleung
approved these changes
Feb 3, 2026
aprilk-ms
added a commit
that referenced
this pull request
Feb 3, 2026
…4950) - Update sample_evaluations_graders.py to use inline data instead of file upload - Update sample_evaluations_ai_assisted.py to use inline data instead of file upload - Update sample_evaluation_cluster_insight.py to use inline data instead of file upload - Add samples/evaluations/README.md as an index for all evaluation samples - Update test_samples_evaluations.py to test the updated samples - Remove unnecessary inline-data sample duplicates - Update assets.json with new recordings
aprilk-ms
added a commit
that referenced
this pull request
Feb 3, 2026
…4950) - Update sample_evaluations_graders.py to use inline data instead of file upload - Update sample_evaluations_ai_assisted.py to use inline data instead of file upload - Update sample_evaluation_cluster_insight.py to use inline data instead of file upload - Add samples/evaluations/README.md as an index for all evaluation samples - Update test_samples_evaluations.py to test the updated samples - Remove unnecessary inline-data sample duplicates - Update assets.json with new recordings
aprilk-ms
added a commit
that referenced
this pull request
Feb 3, 2026
…4950) (#44983) - Update sample_evaluations_graders.py to use inline data instead of file upload - Update sample_evaluations_ai_assisted.py to use inline data instead of file upload - Update sample_evaluation_cluster_insight.py to use inline data instead of file upload - Add samples/evaluations/README.md as an index for all evaluation samples - Update test_samples_evaluations.py to test the updated samples - Remove unnecessary inline-data sample duplicates - Update assets.json with new recordings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 3 new inline-data evaluation samples and include them in the sample recording tests to increase test coverage.
Changes
Why inline-data versions?
The original samples (\sample_evaluations_graders.py, \sample_evaluations_ai_assisted.py, \sample_evaluation_cluster_insight.py) require file uploads to Azure Blob Storage, which is incompatible with test proxy playback. These inline-data versions test the same evaluation functionality without file upload dependencies.
Testing