[Identity] Add RequestIdPolicy to default pipeline policies#46070
Open
pvaneck wants to merge 1 commit intoAzure:mainfrom
Open
[Identity] Add RequestIdPolicy to default pipeline policies#46070pvaneck wants to merge 1 commit intoAzure:mainfrom
pvaneck wants to merge 1 commit intoAzure:mainfrom
Conversation
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-requestid
branch
from
cd0610b to
4311ffb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves request debuggability in azure-identity by ensuring the identity pipeline automatically attaches a client request ID header (x-ms-client-request-id) to outgoing requests.
Changes:
- Added
RequestIdPolicyto the default (sync/async) pipeline policy list inazure.identity._internal.pipeline. - Updated sync/async AAD client tests to assert the
x-ms-client-request-idheader is present. - Documented the change in the
azure-identitychangelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/identity/azure-identity/azure/identity/_internal/pipeline.py | Adds RequestIdPolicy to the default pipeline policies so request IDs are generated/sent automatically. |
| sdk/identity/azure-identity/tests/test_aad_client.py | Verifies the request ID header is present in outgoing token requests (sync). |
| sdk/identity/azure-identity/tests/test_aad_client_async.py | Verifies the request ID header is present in outgoing token requests (async). |
| sdk/identity/azure-identity/CHANGELOG.md | Notes the addition of RequestIdPolicy to default pipeline policies. |
pvaneck
requested review from
KarishmaGhiya,
anannya03,
g2vinay,
joshfree,
maorleger and
minhanh-phan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aids debugging requests.