Remove authoring specific parameters#14623
Merged
jeo02 merged 7 commits intoAzure:mainfrom Mar 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the benchmarks CLI by removing authoring-specific CLI flags and moving authoring overrides into per-testcase JSON configuration, while also extending --repo to support optional git ref overrides (e.g., Owner/Repo:branch) for CI/PR benchmarking.
Changes:
- Removed
--authoring-spec-repo/--authoring-skill-pathCLI options and corresponding discovery plumbing; authoring overrides are now read from JSON test case data. - Added
--repo Owner/Name:refparsing and aBenchmarkOptions.RefOverridesmechanism, applied during workspace preparation. - Updated benchmarks README to document new
--repobehavior and filtering options.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/README.md | Documents --repo filtering/ref override and adds CI/PR branch override guidance. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Program.cs | Removes authoring flags; adds repo parsing/filtering and passes ref overrides into BenchmarkOptions. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Models/RepoConfig.cs | Adds WithRef() and ParseRepoString() helper for Owner/Name[:ref] parsing. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Models/BenchmarkOptions.cs | Adds RefOverrides to carry ref overrides into execution. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Infrastructure/ScenarioDiscovery.cs | Removes authoring override parameters; always loads authoring scenarios from JSON. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Infrastructure/BenchmarkRunner.cs | Applies ref overrides to the scenario repo before workspace preparation. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Infrastructure/AuthoringScenarioLoader.cs | Reads authoringSpecRepo / authoringSkillPath from JSON test cases instead of CLI flags. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-tools into fix-up-authoring
praveenkuttappan
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCases.json---reponow lets you pass in the reference to replicate the behavior done inside ofauthoringSpecRepoOption