[js-sdk-release-tools] bump @typespec/compiler to ^1.0.0#14637
[js-sdk-release-tools] bump @typespec/compiler to ^1.0.0#14637mikeharder merged 1 commit intoAzure:mainfrom
Conversation
mikeharder
requested review from
JialinHuang803,
MaryGao and
qiaozha
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the tools/js-sdk-release-tools toolchain to use TypeSpec compiler v1, bringing dependencies in line with the TypeSpec 1.x ecosystem.
Changes:
- Bump
@typespec/compilerdevDependency from^0.67.1to^1.0.0. - Update
@typespec/compilerpeerDependency from<1.0.0to^1.0.0. - Regenerate
package-lock.jsonto reflect the new resolved dependency graph (including new Node engine requirements).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/js-sdk-release-tools/package.json | Updates TypeSpec compiler dependency + peer dependency to v1. |
| tools/js-sdk-release-tools/package-lock.json | Lockfile refresh for TypeSpec compiler v1 and its updated transitive dependencies. |
Files not reviewed (1)
- tools/js-sdk-release-tools/package-lock.json: Language not supported
| "@types/string-template": "^1.0.6", | ||
| "@types/unixify": "^1.0.2", | ||
| "@typespec/compiler": "^0.67.1", | ||
| "@typespec/compiler": "^1.0.0", | ||
| "rimraf": "^6.0.1", |
There was a problem hiding this comment.
Bumping @typespec/compiler to ^1.x pulls in transitive deps that require Node 20+ (e.g., lockfile now has @typespec/compiler engines.node >=20.0.0 and yargs engines.node ^20.19.0 || ^22.12.0 || >=23). package.json doesn’t declare an engines constraint, so consumers/CI can still run this package on Node 18 and hit install/runtime failures. Add an appropriate engines.node (likely >=20.19.0) and align any build pipelines to that minimum, or keep @typespec/compiler pinned to a version that supports Node 18 if Node 18 must remain supported.
| "peerDependencies": { | ||
| "@typespec/compiler": ">=0.58.0 <1.0.0" | ||
| "@typespec/compiler": "^1.0.0" | ||
| } |
There was a problem hiding this comment.
Changing the peerDependencies range from <1.0.0 to ^1.0.0 is a breaking compatibility change for any consumers still on TypeSpec 0.x. If this package is published/consumed externally, consider either (a) bumping this package’s major version, or (b) widening the peer range to cover both supported major lines (only if the code is actually compatible with both).
| "tsp-server": "cmd/tsp-server.js" | ||
| }, | ||
| "engines": { | ||
| "node": ">=20.0.0" | ||
| } |
There was a problem hiding this comment.
The updated lockfile shows new Node engine requirements introduced by the TypeSpec compiler bump: @typespec/compiler now requires Node >=20.0.0 and yargs@18 requires Node ^20.19.0 || ^22.12.0 || >=23. If this tool (and its CI) still targets Node 18, npm install/runtime may fail. Either raise the supported Node version (and declare it in package.json), or revert/pin dependencies to a Node-18-compatible set.
|
look good. and passed on test pipeleine. |
No description provided.