Regenerate Bicep files with new translator and update baseline#158
Open
jiangmingzhe wants to merge 1 commit intoAzure:mainfrom
Open
Regenerate Bicep files with new translator and update baseline#158jiangmingzhe wants to merge 1 commit intoAzure:mainfrom
jiangmingzhe wants to merge 1 commit intoAzure:mainfrom
Conversation
Comment on lines
+4
to
+6
| var keyspaceName = 'resourcenameks' | ||
| var tableName = 'resourcenametbl' | ||
| var accountName = 'resourcename' |
Member
There was a problem hiding this comment.
This looks like a regression in the generated output
| clientRegistrationEndpoint: 'https://azacceptance.hashicorptest.com/client/register' | ||
| clientSecret: null | ||
| defaultScope: '' | ||
| clientSecret: '${oauthClientSecret}' |
Member
There was a problem hiding this comment.
The interpolation here is unnecessary - instead of:
clientSecret: '${oauthClientSecret}'
It's idiomatic to output:
clientSecret: oauthClientSecret
Comment on lines
+12
to
+15
| publicNetworkAccess: 'Enabled' | ||
| publisherEmail: 'pub1@email.com' | ||
| publisherName: 'pub1' | ||
| virtualNetworkType: 'None' |
Member
There was a problem hiding this comment.
What's the reason for the change in ordering of these properties? Is this to match the original source file?
| tier: 'GeneralPurpose' | ||
| identity: { | ||
| type: 'None' | ||
| userAssignedIdentities: null |
Member
There was a problem hiding this comment.
Should we omit this property entirely instead of setting to null?
| resource policy 'Microsoft.DevTestLab/labs/policySets/policies@2018-09-15' = { | ||
| parent: policySet | ||
| name: 'LabVmCount' | ||
| name: 'policySets/default/LabVmCount' |
Member
There was a problem hiding this comment.
The original code looked more idiomatic here - better to use the parent property with an existing resource, than to use a fully-qualified name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate all the Terraform files with new translator.
The new translator went through an architecture change that make it easier to support more scenarios in future.
Previous translator still has 14 translation failures, while the new translator has zero translation failures, besides the Terraform files that are skipped for translation.