Fix OCL constraint failure on superclass attributes#464
Closed
ArmenSl wants to merge 1 commit intodevelopmentfrom
Closed
Fix OCL constraint failure on superclass attributes#464ArmenSl wants to merge 1 commit intodevelopmentfrom
ArmenSl wants to merge 1 commit intodevelopmentfrom
Conversation
The OCL parser's checkInAttributes() used context.attributes which only returns direct attributes. Changed to context.all_attributes() to include inherited attributes from parent classes. This fixes constraints like self.boss.salary where salary is defined on a superclass of the navigated type. Added 11 tests covering inherited attributes on self, after navigation, in if-then-else, forAll, exists, and mixed with direct attributes.
Collaborator
Author
|
Closing this — the fix is superseded by the new visitor-based OCL implementation (branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #198
One-line fix: changed
context.attributestocontext.all_attributes()in the OCL parser'scheckInAttributes()method (besser/BUML/notations/ocl/FactoryInstance.pyline 9).The method only checked direct attributes of a class, so constraints referencing inherited attributes (e.g.,
self.boss.salarywheresalaryis on a superclass) would fail with "Property not found".Test plan
self.salaryon Employee, salary is on Person)self.boss.salary)