Make appName and key always lowercase to match how subdomains are always lowercase#9
Open
nsmith7989 wants to merge 2 commits intoBackstageJS:masterfrom
Open
Make appName and key always lowercase to match how subdomains are always lowercase#9nsmith7989 wants to merge 2 commits intoBackstageJS:masterfrom
nsmith7989 wants to merge 2 commits intoBackstageJS:masterfrom
Conversation
Collaborator
|
Thanks for the PR, @nsmith7989 ! Just saw it, so sorry for the delay. Will take a look in the next few days :) |
Collaborator
|
@nsmith7989 Well, clearly I never got back to this 😆 Have you tested your branch and it works? If so, could you please just push up a commit that reverts the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue when I was trying to dockerize this. Here's what happened:
Our branch names generally contain a jira issue id which contains capital letters. Something like:
NHCRES-123.If I use the subdomain package resolver this would result in a url like
http://NHCRES-123.myapp.backstage-server.com, which most browsers change tohttp://nhcres-123.myapp.backstage-server.com. If this server is running on a case sensitive file system then package is not found.IMO it is a nicer default to always convert package name (key) and app name to lowercase to solve this issue.