[WIP] init(dockerfile): add additional file#3
[WIP] init(dockerfile): add additional file#3georgettica wants to merge 2 commits intoBash-it:masterfrom
Conversation
currently fails on pypa/virtualenv#1907 if I understand correctly to test run 'docker built -t test -f pre-commit.Dockerfile .' and see the error
georgettica
changed the title
|
@ellerbrock are you still maintaining this repo? |
NoahGorny
left a comment
NoahGorny
left a comment
There was a problem hiding this comment.
@georgettica nice work! I left a couple of comments, but this seems like a nice idea.
pre-commit.Dockerfile
Outdated
| @@ -0,0 +1,61 @@ | |||
| # Developer: | |||
| # --------- | |||
| # Name: Maik Ellerbrock | |||
There was a problem hiding this comment.
I wouldnt write this under Maik's name. as he did not write it, you can write it your name here, it does not bear any responsibility 😄
pre-commit.Dockerfile
Outdated
|
|
||
| FROM bash:5 | ||
|
|
||
| MAINTAINER Maik Ellerbrock |
There was a problem hiding this comment.
Put my name here instead, as Maik is not really present now
| # | ||
| # Description: | ||
| # ----------- | ||
| # Bash Shell v.5 bats and deps for development |
There was a problem hiding this comment.
as I said, lets just use the minimal dockerfile that you wrote for the pre-commit- no need for complicated stuff
|
I'll fix these issues and I am glad you reviewed it :) Thanks |
Co-authored-by: Noah Gorny <noah@gittabags.com>
|
it is 1Gi, if we still want to keep it I am all for it :) you can review again @NoahGorny |
Good job @georgettica ! |
|
Hi @ellerbrock |
2 participants
related to Bash-it/bash-it#1753
currently fails on pypa/virtualenv#1907 if I understand correctly
to test run 'docker built -t test -f pre-commit.Dockerfile .' and see the error