Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
operating-system: [ ubuntu-latest ]
php-versions: [ '7.4' ]
php-versions: [ '8.3' ]
name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
steps:
- name: Checkout
Expand All @@ -29,7 +29,4 @@ jobs:
run: composer validate

- name: Check cs
run: composer cs -- ./

- name: Check psalm
run: composer psalm
run: composer cs -- ./
6 changes: 3 additions & 3 deletions classes/Controllers/Controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ public static function get_current_controller() {
* @return bool
* @author Nicolas Juen
*/
public static function filter_classes( string $class ): bool {
if ( false === is_subclass_of( $class, '\BEA\PB\Controller', true ) ) {
public static function filter_classes( string $class_name ): bool {
if ( false === is_subclass_of( $class_name, '\BEA\PB\Controller', true ) ) {
return false;
}

return $class::get_instance()->is_page();
return $class_name::get_instance()->is_page();
}

/**
Expand Down
2 changes: 1 addition & 1 deletion classes/Cron/Cron.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace BEA\PB;

use \Bea_Log;
use \Bea_Log; //phpcs:ignore Universal.UseStatements.NoLeadingBackslash.LeadingBackslashFound

/**
* This class needs Bea_Log to work
Expand Down
4 changes: 1 addition & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,11 @@
"phpcompatibility/php-compatibility": "9.3.5",
"phpro/grumphp-shim": "v2.18.0",
"squizlabs/php_codesniffer": "3.13.5",
"vimeo/psalm": "6.14.2",
"wp-coding-standards/wpcs": "3.3.0"
},
"scripts": {
"cs": "./vendor/bin/phpcs",
"cb": "./vendor/bin/phpcbf",
"psalm": "./vendor/bin/psalm"
"cb": "./vendor/bin/phpcbf"
},
"suggest": {
"wp-cli/wp-cli": "*@stable"
Expand Down
Loading