-
Notifications
You must be signed in to change notification settings - Fork 0
Chore blueprint #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Chore blueprint #15
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /** | ||
| * Prior save output for validation of existing post content. | ||
| * | ||
| * @see https://developer.wordpress.org/block-editor/reference-guides/block-api/block-deprecation/ | ||
| */ | ||
| import { __ } from '@wordpress/i18n'; | ||
| import { useBlockProps, InnerBlocks, RichText } from '@wordpress/block-editor'; | ||
| import { Icon, close } from '@wordpress/icons'; | ||
|
|
||
| const MODAL_ID_PREFIX = 'modal-'; | ||
|
|
||
| /** | ||
| * Save markup before `screen-reader-text` was added to the close label span (v1.0.4+). | ||
| * | ||
| * @param {Object} props Block props. | ||
| * @param {Object} props.attributes Block attributes. | ||
| * @return {JSX.Element} Element to render. | ||
| */ | ||
| function saveV1CloseLabelSrOnly( { attributes } ) { | ||
| const { | ||
| closedBy, | ||
| displayIconOnly, | ||
| enableCloseButton, | ||
| headingLevel: HeadingTag, | ||
| modalId, | ||
| preventScroll, | ||
| title, | ||
| } = attributes; | ||
|
|
||
| const dialogId = modalId ? MODAL_ID_PREFIX + modalId : undefined; | ||
| const customProps = {}; | ||
|
|
||
| if ( preventScroll ) { | ||
| customProps.className = 'wp-block-blockparty-modal--prevent-scroll'; | ||
| } | ||
|
|
||
| return ( | ||
| <dialog | ||
| { ...useBlockProps.save( customProps ) } | ||
| id={ dialogId } | ||
| aria-modal="true" | ||
| // eslint-disable-next-line react/no-unknown-property | ||
| closedBy={ closedBy } | ||
| > | ||
| <div className="wp-block-blockparty-modal__header"> | ||
| <RichText.Content | ||
| className="wp-block-blockparty-modal__title" | ||
| tagName={ `h${ String( HeadingTag ) }` } | ||
| value={ title } | ||
| /> | ||
| </div> | ||
| <div className="wp-block-blockparty-modal__content"> | ||
| <InnerBlocks.Content /> | ||
| </div> | ||
| { enableCloseButton && closedBy !== 'none' && ( | ||
| <button | ||
| type="button" | ||
| className="wp-block-blockparty-modal__close-button" | ||
| > | ||
| <span className={ displayIconOnly ? 'sr-only' : '' }> | ||
| { __( 'Close this dialog window', 'blockparty-modal' ) } | ||
| </span> | ||
| <Icon icon={ close } /> | ||
| </button> | ||
| ) } | ||
| </dialog> | ||
| ); | ||
| } | ||
|
|
||
| export default [ | ||
| { | ||
| save: saveV1CloseLabelSrOnly, | ||
| }, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated PHP code causes blueprint syntax error
High Severity
The
runPHPcodevalue contains the entire PHP script duplicated and nested inside itself. The string starts with<?php require_once 'wordpress/wp-load.php'; $page_content = '<?php require_once 'wordpress/wp-load.php'; $page_content = '.... PHP will terminate the single-quoted$page_contentstring at the inner'wordpressquote, causing a parse error. The intended code (a singlerequire_once, one$page_contentassignment, and onewp_insert_postcall) appears twice, with the outer copy wrapping the inner one. TherunPHPstep will fail, the page won't be created, and thelandingPagepointing topost=4will likely 404 or open the wrong post.