-
Notifications
You must be signed in to change notification settings - Fork 0
Release 1.0.5 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 1.0.5 #17
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2f01612
Merge pull request #10 from BeAPI/ver/1.0.4
firestar300 5627223
Merge pull request #13 from BeAPI/chore/blueprint
firestar300 ee407a4
fix(modal): add screen-reader-text class to close button
firestar300 e3ea80c
chore(blueprint): setup demo page and update landing page
firestar300 d869de1
chore: releases version 1.0.5
firestar300 7113d85
fix(modal): add deprecation for v1.0.4 markup changes
firestar300 fb71f84
Merge pull request #15 from BeAPI/chore/blueprint
firestar300 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "version": "1.0.4", | ||
| "version": "1.0.5", | ||
| "slug": "blockparty-modal" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /** | ||
| * Prior save output for validation of existing post content. | ||
| * | ||
| * @see https://developer.wordpress.org/block-editor/reference-guides/block-api/block-deprecation/ | ||
| */ | ||
| import { __ } from '@wordpress/i18n'; | ||
| import { useBlockProps, InnerBlocks, RichText } from '@wordpress/block-editor'; | ||
| import { Icon, close } from '@wordpress/icons'; | ||
|
|
||
| const MODAL_ID_PREFIX = 'modal-'; | ||
|
|
||
| /** | ||
| * Save markup before `screen-reader-text` was added to the close label span (v1.0.4+). | ||
| * | ||
| * @param {Object} props Block props. | ||
| * @param {Object} props.attributes Block attributes. | ||
| * @return {JSX.Element} Element to render. | ||
| */ | ||
| function saveV1CloseLabelSrOnly( { attributes } ) { | ||
| const { | ||
| closedBy, | ||
| displayIconOnly, | ||
| enableCloseButton, | ||
| headingLevel: HeadingTag, | ||
| modalId, | ||
| preventScroll, | ||
| title, | ||
| } = attributes; | ||
|
|
||
| const dialogId = modalId ? MODAL_ID_PREFIX + modalId : undefined; | ||
| const customProps = {}; | ||
|
|
||
| if ( preventScroll ) { | ||
| customProps.className = 'wp-block-blockparty-modal--prevent-scroll'; | ||
| } | ||
|
|
||
| return ( | ||
| <dialog | ||
| { ...useBlockProps.save( customProps ) } | ||
| id={ dialogId } | ||
| aria-modal="true" | ||
| // eslint-disable-next-line react/no-unknown-property | ||
| closedBy={ closedBy } | ||
| > | ||
| <div className="wp-block-blockparty-modal__header"> | ||
| <RichText.Content | ||
| className="wp-block-blockparty-modal__title" | ||
| tagName={ `h${ String( HeadingTag ) }` } | ||
| value={ title } | ||
| /> | ||
| </div> | ||
| <div className="wp-block-blockparty-modal__content"> | ||
| <InnerBlocks.Content /> | ||
| </div> | ||
| { enableCloseButton && closedBy !== 'none' && ( | ||
| <button | ||
| type="button" | ||
| className="wp-block-blockparty-modal__close-button" | ||
| > | ||
| <span className={ displayIconOnly ? 'sr-only' : '' }> | ||
| { __( 'Close this dialog window', 'blockparty-modal' ) } | ||
| </span> | ||
| <Icon icon={ close } /> | ||
| </button> | ||
| ) } | ||
| </dialog> | ||
| ); | ||
| } | ||
|
|
||
| export default [ | ||
| { | ||
| save: saveV1CloseLabelSrOnly, | ||
| }, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated PHP code in blueprint runPHP step
High Severity
The
codefield in therunPHPstep contains the entire PHP snippet duplicated — the full script is nested inside itself as the value of$page_content. The outer copy opens a single-quoted string ($page_content = '<?php require_once ') which is immediately terminated by the unescaped single quote beforewordpressin the inner copy, causing a PHP parse error. The WordPress Playground blueprint will fail to create the demo page.