change column naming in the conditions table#301
Open
plakrisenko wants to merge 1 commit intomasterfrom
Open
Conversation
dilpath
approved these changes
Feb 18, 2026
Collaborator
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Thanks, it does look unclear. PR is fine for me as is, but maybe *_pretreatment_start_time is most clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the values in the renamed columns are not incubation times, but time points of administration.
E.g. for the experiment
JI09_150302_Drg345_343_CycNuc, Fsk was added at t=60min and the measurements we taken at t=65min. It should be that the longer the incubation time (60 - value in the column) with Rp- cAMP analog, the smaller the pRII_Microscopy value.Figure from the paper: