Conversation
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
generally looks good - rw+c. most of my comments are minor. you might want to ask Anna to look at this, too.
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
This looks mostly good, just a few nits. However, it looks like rails app:update wasn't run, similar to what happened at the beginning of BerkeleyLibrary/UCBEARS#21. Can you make sure that's run and the configuration files are updated appropriately? I described how to do that in the UCBEARS MR.
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
We're quite close! Luckily there aren't too many new configurations it found for 8.0. I'm not sure about 7.1 and 7.2; you may need to step each one of those as well.
You don't need to do each one, since some of them are obviously not going to affect us (old IE support and the like). The main ones I'm concerned about from 7.1 and 7.2 are the Postgres adaptor settings and YJIT.
|
To be clear, you can download the 7.1 and 7.2 files I linked above and put them in |
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
r+wc; I think we can drop the Rails 7.1 explicit setting, and then this should be good.
Thank you so much for your diligence through all these updates; I know it isn't easy or fun. You rocked it though!
config/application.rb
Outdated
|
|
||
| # Rails 7.1 default: do not add autoload paths to $LOAD_PATH. | ||
| # Reduces load path size and avoids manual requires for autoloaded code. | ||
| config.add_autoload_paths_to_load_path = false |
There was a problem hiding this comment.
Do we need this if we are now loading 8.0 defaults?
There was a problem hiding this comment.
Ahhh, I needed it while testing, but yeah, seems it's unnecessary now using 8.0!
3 participants
Upgrade Rails and dependencies to 8.0.x