Add gap between line numbers when word wrap is on#102
Open
blazetill wants to merge 9 commits intoBertrandBev:masterfrom
Open
Add gap between line numbers when word wrap is on#102blazetill wants to merge 9 commits intoBertrandBev:masterfrom
blazetill wants to merge 9 commits intoBertrandBev:masterfrom
Conversation
- Add textInputAction and enableSuggestions parameters - Add automatic completion feature - Fix emoji and special character rendering - Add smartDashesType support - Fix iOS horizontal scroll issue - Keep local fieldKey parameter
- Fix indentation for smartDashesType comment - Fix TextField constructor formatting
When wrap=true, long lines create multiple visual rows but line numbers only showed logical line count. Now TextPainter measures each line's visual height and inserts blank placeholders to keep line numbers synchronized with wrapped content. - Calculate visual line count using TextPainter.layout() - Insert empty line number placeholders for wrapped visual lines - Recalculate on width changes to maintain alignment - Handle non-numeric placeholders in LineNumberController
fix(code-field): align line numbers with wrapped text lines
Now the line wrapping and line numbers should be synced
Calculate the available width from a closer LayoutBuilder
blazetill
changed the title
Owner
|
Thank you for those good additions ! |
|
is this going to be merged? this is a pretty important detail :l |
Owner
Sure, as soon as you remove the print statement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes this issue
Not sure about the performance, it's fast enough for my use case.
Otherwise it also