Skip to content

Updated hero design #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Billson7 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Updated hero design #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
681fc91
updated hero design
Billson7 Jun 6, 2025
b68f8e2
adjust background colours
Billson7 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 68 additions & 12 deletions src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
.page-section {
display: block;
overflow: hidden;
background: #f5f5f7;
}

.section-content {
margin-inline-start: auto;
margin-inline-end: auto;
max-width: 692px;
}

.section {
Expand Down Expand Up @@ -55,23 +62,69 @@
margin-right: auto;
}

.profile-image {
width: 550px;
height: 275px;
clip-path: circle();
.hero-tile {
display: flex;
flex-direction: row;
min-width: 100%;

@media screen and (max-width: 749px) {
flex-direction: column;
}
}

.tile-media {
width: 100%;
height: auto;
max-height: 400px;
flex-basis: 400px;
flex-shrink: 1;
overflow: hidden;
border-radius: 25px 0 0 25px;
}

.tile-content {
display: flex;
flex-direction: column;
padding: 24px;
width: 40%;
text-align: left;
}

.hero-tile {
justify-content: space-between;
flex-basis: 0;
background: #fff;
border-radius: 25px;
}

.profile-image {
object-fit: cover;
object-position: 0 38%;
object-position: 80% 100%;
width: auto;
height: auto;
max-width: 450px;
max-height: 525px;
position: relative;
}

.profile-heading {
margin-bottom: 0;
font-size: 64px;
font-size: 28px;
line-height: 1.1904761905;
font-weight: 700;
letter-spacing: .011em;
font-family: "SF Pro Display", "SF Pro Icons", "Helvetica Neue", "Helvetica",
"Arial", sans-serif;
}

.profile-caption {
color: #86868b;
margin: 0;
font-size: 12px;
line-height: 1.3333733333;
font-weight: 700;
letter-spacing: -0.01em;
font-family: "SF Pro Text", "SF Pro Icons", "Helvetica Neue", "Helvetica",
"Arial", sans-serif;
margin-bottom: 24px;
color: #6e6e73;
}

.profile-caption-invert {
Expand All @@ -80,9 +133,12 @@
}

.profile-intro {
font-size: 24px;
width: 80%;
margin: 50px auto;
font-size: 21px;
line-height: 1.1904761905;
font-weight: 700;
letter-spacing: .011em;
font-family: "SF Pro Display", "SF Pro Icons", "Helvetica Neue", "Helvetica",
"Arial", sans-serif;
}

.biscuit-image-row {
Expand Down
4 changes: 3 additions & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ export const App: FC = () => {

return (
<main className="page-section">
<Hero {...heroContent} />
<div className="section-content">
<Hero {...heroContent} />
</div>
<Biscuit {...biscuitContent} />
<Work {...workContent} />
<Cool {...coolContent} />
Expand Down
Binary file added src/components/HeroSection/Assets/profile-picture.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
39 changes: 20 additions & 19 deletions src/components/HeroSection/hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,28 @@
import React, { type FC } from 'react';
import type { BasicContent } from '../../../types';
import profilePicture from './Assets/profile-picture.jpeg';
import profilePicture from './Assets/profile-picture.png';

export const Hero: FC<BasicContent> = ({ heading, caption, intro }) => (
<section className="section section-hero">
<div className="flex-row">
<img
src={profilePicture}
alt="profile of Alex"
className="profile-image"
/>
<h2 className="profile-heading" data-testid="profile-heading">
{heading}
</h2>
<p className="profile-caption" data-testid="profile-caption">
{caption}
</p>
<p className="profile-intro" data-testid="profile-intro">
{intro}
</p>
<code style={{ display: 'none' }}>
need a graphic here to push the other sections out of initial view
</code>
<div className="hero-tile">
<div className="tile-media">
<img
src={profilePicture}
alt="profile of Alex"
className="profile-image"
/>
</div>
<div className="tile-content">
<div className="profile-caption" data-testid="profile-caption">
{caption}
</div>
<div className="profile-heading" data-testid="profile-heading">
{heading}
<div className="profile-intro" data-testid="profile-intro">
{intro}
</div>
</div>
</div>
</div>
</section>
);
2 changes: 1 addition & 1 deletion src/fixtures/content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const content = {
hero: {
heading: 'Alex Billson',
caption: '://developer',
caption: 'Senior Software Engineer',
intro: 'Software engineer, coffee enthusiast'
},
biscuit: {
Expand Down