Conversation
Makefile.am
Outdated
|
|
||
|
|
||
| # Check the C++ source code for white-space errors with clang-format. | ||
|
|
There was a problem hiding this comment.
Please remove this blank line.
Makefile.am
Outdated
| if ls *.fixed; then exit 1; fi | ||
|
|
||
| # Check the C++ source code for errors with clang-tidy. | ||
|
|
There was a problem hiding this comment.
Please remove this blank line.
azure-pipelines.yml
Outdated
| - script: make clang-format | ||
| displayName: Run clang-format | ||
| - script: make clang-tidy | ||
| displayName: Run clang-tidy No newline at end of file |
There was a problem hiding this comment.
This odd 🚫 icon above indicates that you have removed the final line feed from the file, and so this line has no line feed. Please configure your text editor to ensure that the file ends with a line feed. I recommend using Vim (MacVim on macOS) or Microsoft Visual Studio Code.
Makefile.am
Outdated
| # Check the C++ source code for errors with clang-tidy. | ||
|
|
||
| clang-tidy: | ||
| clang-tidy -warnings-as-errors='*' *.hpp *.h */*.cpp Tests/*/*.*pp -- -std=c++11 -x c++ -I./vendor No newline at end of file |
There was a problem hiding this comment.
This odd 🚫 icon above indicates that you have removed the final line feed from the file, and so this line has no line feed. Please configure your text editor to ensure that the file ends with a line feed. I recommend using Vim (MacVim on macOS) or Microsoft Visual Studio Code.
|
|
|
This PR must pass CI before merging. One way to do that is to make the necessary fixes to silence the |
I'll do this in a separate PR since I'll have to change the regex for the clang-format too. I didn't catch was vendor library too. |
|
Is this PR the next to be merged? |
|
hmm I don't know how much work it will take to clear all the errors. My original plan was to make the 1.2.0 release then do the clang-tidy work. |
|
That sounds good. |
2 participants
The error from CI is only from clang-tidy.