Conversation
Contributor
kisslove-dewangan
left a comment
kisslove-dewangan
left a comment
There was a problem hiding this comment.
just check whether there could be some wallet fields which is relevant to log or not. rest all lgtm
kisslove-dewangan
previously requested changes
Jan 19, 2026
Contributor
kisslove-dewangan
left a comment
kisslove-dewangan
left a comment
There was a problem hiding this comment.
just check whether there could be some wallet fields which is relevant to log or not. rest all lgtm
Contributor
Author
Makes sense, we would need the wallet field to debug. Updating this. |
ayush-9
previously approved these changes
Jan 19, 2026
Marzooqa
force-pushed
the
WP-7489
branch
2 times, most recently
from
581a942 to
1d3fd0c
Compare
adityasoni-bitgo
previously approved these changes
Jan 19, 2026
ayush-9
approved these changes
Jan 19, 2026
ayush-9
requested changes
Jan 19, 2026
biwwy0
previously approved these changes
Jan 19, 2026
ayush-9
previously approved these changes
Jan 19, 2026
ayush-9
reviewed
Jan 19, 2026
There was a problem hiding this comment.
Pull request overview
This pull request addresses sanitization in BitGo Express logs when transaction validation fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lokesh-bitgo
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When prebuildAndSignTransaction fails validation, the logged txPrebuild object, this pr aims to sanitize this for the BitGo Express logs.
Changes:
Sanitizing the preBuild object before logging.
TICKET: WP-7489