feat(abstract-utxo): improve transaction signing test coverage#8041
Merged
OttoAllmendinger merged 3 commits intomasterfrom Feb 4, 2026
Merged
feat(abstract-utxo): improve transaction signing test coverage#8041OttoAllmendinger merged 3 commits intomasterfrom
OttoAllmendinger merged 3 commits intomasterfrom
Conversation
Add comprehensive tests for signTransaction functionality, covering: - PSBT with taprootKeyPathSpend inputs - PSBT without taprootKeyPathSpend inputs - Network transactions - Error handling for cache misses and unsupported locking scripts - Validation of signature and nonce counts Issue: BTC-2866 Co-authored-by: llm-git <llm-git@ttll.de>
Refactor transaction test suite to simplify script type selection logic. Replace multiple individual test combinations with a unified approach that dynamically selects appropriate script types based on coin and transaction format. Issue: BTC-2866 Co-authored-by: llm-git <llm-git@ttll.de>
Use a minimal subset of test coins (BTC, BCH, ZEC) that provides full feature coverage while significantly reducing test runtime. Refactor test utilities to support this optimization: - Add `getMinUtxoCoins()` helper function - Move shared code like `getScriptTypes()` and `TxFormat` to utilities - Improve validation logic for different script types Issue: BTC-2866 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the UTXO transaction signing test infrastructure with
three main improvements:
Move sign signTransaction tests to separate file
Simplify test script configuration
Optimize test suite performance
BTC-2866