Skip to content

feat(abstract-utxo): simplify BIP322 message verification #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidkaplanbitgo merged 1 commit into from
Feb 3, 2026
Merged

feat(abstract-utxo): simplify BIP322 message verification #8046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,17 +318,10 @@ function getBip322MessageInfoAndVerify(psbt: bitgo.UtxoPsbt, coinName: UtxoCoinN
if (!input.witnessUtxo) {
throw new Error(`Missing witnessUtxo for input index ${i}`);
}
if (!input.nonWitnessUtxo) {
throw new Error(`Missing nonWitnessUtxo for input index ${i}`);
}
const scriptPubKey = input.witnessUtxo.script;

// Verify that the toSpend transaction can be recreated in the PSBT and is encoded correctly in the nonWitnessUtxo
const toSpend = bip322.buildToSpendTransaction(scriptPubKey, message);
const toSpendB64 = toSpend.toBuffer().toString('base64');
if (input.nonWitnessUtxo.toString('base64') !== toSpendB64) {
throw new Error(`Non-witness UTXO does not match the expected toSpend transaction at input index ${i}`);
}

// Verify that the toSpend transaction ID matches the input's referenced transaction ID
if (toSpend.getId() !== utxolib.bitgo.getOutputIdForInput(psbt.txInputs[i]).txid) {
Expand Down
Loading