Skip to content

refactor(sdk-coin-ada): ignore fee address outputs for consolidation #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veetragjain merged 1 commit into from
Feb 6, 2026
Merged

refactor(sdk-coin-ada): ignore fee address outputs for consolidation #8064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/sdk-coin-ada/src/ada.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ export interface TransactionPrebuild {
txHex: string;
}

export interface AdaTxInfo {
feeAddress?: string;
}

export interface ExplainTransactionOptions {
txPrebuild: TransactionPrebuild;
}
Expand Down Expand Up @@ -145,9 +149,10 @@ export class Ada extends BaseCoin {
}
} else if (verification?.consolidationToBaseAddress) {
const baseAddress = wallet.coinSpecific()?.baseAddress || wallet.coinSpecific()?.rootAddress;
const feeAddress = (txPrebuild.txInfo as AdaTxInfo)?.feeAddress;

for (const output of explainedTx.outputs) {
if (output.address !== baseAddress) {
if (output.address !== baseAddress && output.address !== feeAddress) {
throw new Error('tx outputs does not match with expected address');
}
}
Expand Down
74 changes: 74 additions & 0 deletions modules/sdk-coin-ada/test/unit/ada.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,80 @@ describe('ADA', function () {
}
});

it('should verify a valid sponsored consolidation transaction', async () => {
const consolidationTx = {
txRequestId: '1b5c79c5-ab7c-4f47-912b-de6a95fb0779',
walletId: '64fa31a94db65a0007c9691b',
txHex:
'84a40082825820227f65d20ac6e49602d79c623c51911ead824235e01eb2a1e7e33a72f0747cbb00825820227f65d20ac6e49602d79c623c51911ead824235e01eb2a1e7e33a72f0747cbb0201828258390022098270a5c19c9fb706dce0e7e4566b234ec5f0010623cd63f198ad22098270a5c19c9fb706dce0e7e4566b234ec5f0010623cd63f198ad1a0098968082581d60cf90f9fb02c88bad3c5294d90587458c4f160a2db26ba8af3da255b11a05d42fb8021a0002a491031a06d8c048a0f5f6',
feeInfo: {
fee: 165545,
feeString: '165545',
},
txInfo: {
minerFee: '165545',
spendAmount: '999834455',
spendAmounts: [
{
coinName: 'tada',
amountString: '999834455',
},
],
payGoFee: '0',
outputs: [
{
address:
'addr_test1qprqrlqpdtpctqy3d56jp0rkkevjnq2kqzrn356842f3gt6xq87qz6krskqfzmf4yz78ddje9xq4vqy88rf5025nzshsjdmg2s',
value: 999834455,
wallet: '64fa31a94db65a0007c9691b',
wallets: ['64fa31a94db65a0007c9691b'],
enterprise: '62cc59b727443a0007089033',
enterprises: ['62cc59b727443a0007089033'],
valueString: '999834455',
coinName: 'tada',
walletType: 'hot',
walletTypes: ['hot'],
},
],
inputs: [
{
value: 1000000000,
address:
'addr_test1qqlzxfl7tlgp999x4a7334pchycpkk72pykrsr3mryl3yj6xq87qz6krskqfzmf4yz78ddje9xq4vqy88rf5025nzshsvpgl8w',
valueString: '1000000000',
},
],
type: '0',
feeAddress: 'addr_test1vr8ep70mqtyghtfu222djpv8gkxy79s29kexh2908k39tvge02d5j',
},
consolidateId: '68b9fc18558006aab53785615fea7c28',
coin: 'tada',
};

const mockedWallet = {
coinSpecific: () => {
return {
rootAddress:
'addr_test1qq3qnqns5hqee8ahqmwwpely2e4jxnk97qqsvg7dv0ce3tfzpxp8pfwpnj0mwpkuurn7g4ntyd8vtuqpqc3u6cl3nzksvggu82',
};
},
};

try {
const isVerified = await basecoin.verifyTransaction({
txParams: {},
txPrebuild: consolidationTx,
wallet: mockedWallet,
verification: {
consolidationToBaseAddress: true,
},
});
isVerified.should.equal(true);
} catch (e) {
assert.fail('Transaction should pass verification');
}
});

it('should fail to sign a spoofed consolidation transaction', async function () {
// Set up wallet data
const walletData = {
Expand Down