feat(statics): add Hemi EVM chain support#8147
Open
manojkumar138 wants to merge 1 commit intomasterfrom
Open
Conversation
manojkumar138
force-pushed
the
coin-onboard/hemi
branch
2 times, most recently
from
ae132d4 to
3e5fe7b
Compare
| ], | ||
| KeyCurve.Secp256k1, | ||
| '', | ||
| 'Hemi' |
Contributor
There was a problem hiding this comment.
Why do we need suffix for hemi?
Contributor
Author
There was a problem hiding this comment.
Removed them now.
| n.asset !== UnderlyingAsset.FLUENTETH && | ||
| n.asset !== UnderlyingAsset.MANTLE && | ||
| n.asset !== UnderlyingAsset.JOVAYETH && | ||
| n.asset !== UnderlyingAsset.HEMI && |
Contributor
There was a problem hiding this comment.
We don't need to add new coins to this, as the implementation is already available in the common evm module
Comment on lines
2271
to
2272
| CoinFeature.EVM_NON_BITGO_RECOVERY, | ||
| CoinFeature.EVM_UNSIGNED_SWEEP_RECOVERY, |
Contributor
There was a problem hiding this comment.
Let's add these CoinFeatures later - when we are ready for adding recovery support.
As things stand, no one will be able to bump SDK in WRW without corresponding config changes for the new coin in WRW
Add Hemi Ethereum L2 chain with ETH gas token: - Add hemieth/themieth coin entries in allCoinsAndTokens - Add HEMIETH to CoinFamily and UnderlyingAsset enums - Add HemiEth network classes with chain IDs 43111/743111 - Add OFC entries for ofchemieth/ofcthemieth - Add explorer API configuration in environments - Update test fixtures Ticket: WIN-8747 CECHO-115
manojkumar138
force-pushed
the
coin-onboard/hemi
branch
from
68d9ded to
f4afcd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CECHO-115