fix(sdk-coin-vet): improve error messages for delegation/validator mutual exclusivity#8487
Closed
Gautam2305 wants to merge 1 commit intomasterfrom
Closed
fix(sdk-coin-vet): improve error messages for delegation/validator mutual exclusivity#8487Gautam2305 wants to merge 1 commit intomasterfrom
Gautam2305 wants to merge 1 commit intomasterfrom
Conversation
…tual exclusivity When a user attempts to delegate from a wallet with an active validator registration (or vice versa), the previous error message reported an address mismatch without explaining the underlying constraint. The user would see a cryptic message like "Invalid staking contract address. Expected 0x03c... got 0x000..." with no indication of why. The fix detects when the provided contract address belongs to the opposing operation's contract, and surfaces a clear human-readable error explaining that the two operations are mutually exclusive for a given wallet. Generic address-mismatch errors are preserved for all other invalid addresses. Ticket: SI-305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user attempts to delegate from a wallet with an active validator registration (or vice versa), the previous error message reported a raw address mismatch with no explanation of the underlying constraint.
This PR improves both
validateStakingContractAddressandvalidateContractAddressForValidatorRegistrationinutils.tsto detect cross-contract mismatches and surface a clear, human-readable error explaining that delegation and validator registration are mutually exclusive for a given wallet.Ticket: SI-305