fix(wasm-utxo): correct paygo address validation in tests#167
Open
OttoAllmendinger wants to merge 2 commits intomasterfrom
Open
fix(wasm-utxo): correct paygo address validation in tests#167OttoAllmendinger wants to merge 2 commits intomasterfrom
OttoAllmendinger wants to merge 2 commits intomasterfrom
Conversation
This commit fixes an issue with PayGo attestation validation by updating the test address from "1CdWUVacSQQJ617HuNWByGiisEGXGNx2c" to "1CdWUVacSQQJ617HfuNWByGiisEGXGNx2c" and its corresponding script pubkey. Enables proper signature verification in tests that were previously failing or ignored. Issue: BTC-2650 Co-authored-by: llm-git <llm-git@ttll.de>
Refactor the PSBT transaction parsing interface to use structured options objects instead of individual parameters. This improves readability and makes the API more maintainable for future extensions. Specifically: - Add `ParseTransactionOptions` and `ParseOutputsOptions` types - Update `parseTransactionWithWalletKeys` and `parseOutputsWithWalletKeys` to use these option objects - Update all call sites to use the new API pattern Issue: BTC-2650 Co-authored-by: llm-git <llm-git@ttll.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with PayGo attestation validation by updating
the test address from "1CdWUVacSQQJ617HuNWByGiisEGXGNx2c" to
"1CdWUVacSQQJ617HfuNWByGiisEGXGNx2c" and its corresponding script
pubkey. Enables proper signature verification in tests that were
previously failing or ignored.
Issue: BTC-2650