Skip to content

fix: replace bare except clauses with except Exception #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taovinci0 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Open

fix: replace bare except clauses with except Exception #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gas/scraping/google.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def _extract_full_size_urls_by_clicking(self, browser, limit):
break
if full_size_img:
break
except:
except Exception:
continue

if full_size_img and full_size_img not in image_urls:
Expand All @@ -385,7 +385,7 @@ def _extract_full_size_urls_by_clicking(self, browser, limit):
time.sleep(random.uniform(0.2, 0.8))
close_button.click()
time.sleep(random.uniform(0.3, 0.7))
except:
except Exception:
pass

except Exception as e:
Expand Down
2 changes: 1 addition & 1 deletion gas/utils/chain_model_metadata_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ async def retrieve_model_metadata(
bt.logging.info(f"chain_str: {chain_str}")
try:
model_id = ModelId.from_compressed_str(chain_str)
except:
except Exception:
bt.logging.trace(
f"Failed to parse the metadata on the chain for hotkey {hotkey}."
)
Expand Down
8 changes: 4 additions & 4 deletions gas/utils/huggingface_uploads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def upload_media_to_hf(

try:
create_repo(dataset_repo, repo_type="dataset", exist_ok=True, token=hf_token)
except:
except Exception:
pass

archive_operations = []
Expand Down Expand Up @@ -177,7 +177,7 @@ def upload_media_to_hf(
for temp_file in all_temp_files:
try:
os.unlink(temp_file)
except:
except Exception:
pass

return successfully_processed_ids
Expand Down Expand Up @@ -582,7 +582,7 @@ def create_image_archives(
for temp_file in temp_files_to_cleanup:
try:
os.unlink(temp_file)
except:
except Exception:
pass
raise

Expand Down Expand Up @@ -661,7 +661,7 @@ def create_video_archives(
for temp_file in temp_files_to_cleanup:
try:
os.unlink(temp_file)
except:
except Exception:
pass
raise

Expand Down
2 changes: 1 addition & 1 deletion neurons/validator/services/generator_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ def _run_verification(self):
try:
from gas.verification import clear_clip_models
clear_clip_models()
except:
except Exception:
pass

def _cleanup(self):
Expand Down