Skip to content

fix(jadepy): avoid blocking large serial reads#292

Draft
Bortlesboat wants to merge 1 commit intoBlockstream:masterfrom
Bortlesboat:codex/jade-cbor2-timeout-286
Draft

fix(jadepy): avoid blocking large serial reads#292
Bortlesboat wants to merge 1 commit intoBlockstream:masterfrom
Bortlesboat:codex/jade-cbor2-timeout-286

Conversation

@Bortlesboat
Copy link
Copy Markdown

Summary

  • add a focused regression test for JadeSerialImpl.read()
  • read only buffered bytes when data is already waiting instead of always requesting the full chunk
  • fall back to a 1-byte blocking read when nothing is buffered

Testing

  • python -m unittest discover -s tests -p test_jade_serial.py -v

@jgriffiths
Copy link
Copy Markdown
Collaborator

Please do not submit AI patches without noting you have done so.

Also please provide some kind of rationale for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants