Skip to content

Remove unused Clone derive from TxFeeInfo#180

Closed
Copilot wants to merge 3 commits intomempool-increase-patchfrom
copilot/sub-pr-179
Closed

Remove unused Clone derive from TxFeeInfo#180
Copilot wants to merge 3 commits intomempool-increase-patchfrom
copilot/sub-pr-179

Conversation

Copy link

Copilot AI commented Feb 5, 2026

The Clone derive on TxFeeInfo was added to support passing cloned fee info to BacklogStats::from_feeinfo_slice, but the implementation uses &[&TxFeeInfo] instead—no cloning occurs.

Changes:

  • Removed #[derive(Clone)] from TxFeeInfo struct in src/util/fees.rs

The struct fields (u64, u64, f64) are small enough that cloning would be cheap if needed, but since references are passed throughout the codebase, the derive is unnecessary.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: shesek <877904+shesek@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 5, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • bitcoincore.org
    • Triggering command: /home/REDACTED/work/electrs/electrs/target/debug/build/bitcoind-c3f6f68d63302427/build-script-build /home/REDACTED/work/electrs/electrs/target/debug/build/bitcoind-c3f6f68d63302427/build-script-build -I /home/REDACTED/work/electrs/electrs/target/debug/build/zmq-sys-f86306147ad5986a/ou-o --gdwarf-4 --64 -o /home/REDACTED/work/electrs/electrs/target/debug/build/zmq-sys-f86306147ad5986a/out/lib/efa3cec3213c0f7a-poller_base.o /tmp/cc0MP6In.s f/zeromq-src-0.2as t/lib/efa3cec3213c0f7a-plain_client.o f/zeromq-src-0.2/home/REDACTED/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zeromq-src-0.2--error-format=json f/zeromq-src-0.2-I .6&#43;4.3.4/vendor/include 306147ad5986a/ou-I .6&#43;4.3.4/vendor/src cal/bin/as .6&#43;4.3.4/vendor/src 306147ad5986a/ou-I .6&#43;4.3.4/vendor/external/sha1 rgo/registry/src-I (dns block)
  • https://api.github.com/repos/Blockstream/rust-electrum-client/commits/d3792352992a539afffbe11501d1aff9fd5b919d
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.75.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.75.0-x86_64-REDACTED-linux-gnu/bin/cargo check --all-targets (http block)
  • https://api.github.com/repos/shesek/electrumd/commits/b35d9db285d932cb3c2296beab65e571a2506349
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.75.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.75.0-x86_64-REDACTED-linux-gnu/bin/cargo check --all-targets (http block)
  • https://api.github.com/repos/shesek/rust-jsonrpc/commits/aaa0af349bd4885a59f6f6ba1753e78279014f98
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.75.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.75.0-x86_64-REDACTED-linux-gnu/bin/cargo check --all-targets (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix mempool tuning for larger mempool size Remove unused Clone derive from TxFeeInfo Feb 5, 2026
Copilot AI requested a review from shesek February 5, 2026 11:32
@shesek shesek closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants