Remove unused Clone derive from TxFeeInfo#180
Closed
Copilot wants to merge 3 commits intomempool-increase-patchfrom
Closed
Remove unused Clone derive from TxFeeInfo#180Copilot wants to merge 3 commits intomempool-increase-patchfrom
Copilot wants to merge 3 commits intomempool-increase-patchfrom
Conversation
8a8a46c to
884a102
Compare
Co-authored-by: shesek <877904+shesek@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix mempool tuning for larger mempool size
Remove unused Clone derive from TxFeeInfo
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Clonederive onTxFeeInfowas added to support passing cloned fee info toBacklogStats::from_feeinfo_slice, but the implementation uses&[&TxFeeInfo]instead—no cloning occurs.Changes:
#[derive(Clone)]fromTxFeeInfostruct insrc/util/fees.rsThe struct fields (
u64,u64,f64) are small enough that cloning would be cheap if needed, but since references are passed throughout the codebase, the derive is unnecessary.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.