network_parameters: change bip21 schema liquidtestnet->liquidnetwork#206
Open
network_parameters: change bip21 schema liquidtestnet->liquidnetwork#206
Conversation
Contributor
|
ACK 71937f6 I would add a changelog entry though. |
|
Concept NAK. Bitcoin's overloading of the |
Contributor
|
ACK 381f03c, we should do the same as bitcoin |
the schema doesn't need to convey the network, indeed for bitcoin we have only `bitcoin:` as schema for every network (mainnet, testnet, signet, regtest) This is indeed a breaking change and the liquidtesnet schema is used in the wild, however, since it's breaking only for testnet networks, it makes sense to change it.
381f03c to
0d09b75
Compare
Member
|
concept ack 5ff8e7e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bip21 schema doesn't need to convey the network, indeed for bitcoin we have only
bitcoin:as schema for every network (mainnet, testnet, signet, regtest)This is indeed a breaking change and the
liquidtesnetschema is used in the wild, however, since it's breaking only for testnet networks, I think it makes sense to change it.@angelix @lvaccaro @LeoComandini @jgriffiths @jkauffman1 @domegabri @whitslack @alessandro-saglimbeni
related ElementsProject/elements#805