DO NOT MERGE: update vendored simplicity#350
Draft
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Draft
DO NOT MERGE: update vendored simplicity#350stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge.
The intention of this PR is to update the vendored simplicity code so that the names of the deprecated jets are updated, and also to add in the generated code for marking deprecated code in simplicity#333
However, I've marked it as Do Not Merge because I can see some errors (which I am not 100% sure how to fix):
I've decided to open it as a draft anyway so that it's easy to reference when discussing.