Separate Jet env from Jet trait#351
Open
ivanlele wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
Separate Jet env from Jet trait#351ivanlele wants to merge 1 commit intoBlockstreamResearch:masterfrom
ivanlele wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
Contributor
Author
|
It might look large, but most of the changes are in the auto-generated jet implementations and consist mainly of formatting and moving code around. This also raises a question: should we update the Haskell-Rust codegen for these implementations now, or leave it for later? The other changes are relatively few, but nonetheless far more important. |
Contributor
Author
|
Also, while updating interfaces in some files, I ran cargo fmt on the files I was modifying, so you might notice a few lines that were reformatted as a result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is one of several that will make the
Jettrait object-safe (see #349).It introduces a new trait,
JetEnvironment, which movesc_jet_env,c_jet_ptr, andCJetEnvironmentinto it fromJet.