fix(prune): preserve case target when pruning case -> assert#352
Open
tvolk131 wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
fix(prune): preserve case target when pruning case -> assert#352tvolk131 wants to merge 1 commit intoBlockstreamResearch:masterfrom
tvolk131 wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a pruning/type-inference edge case in RedeemNode::prune_with_tracker() where pruning a case into assertl/assertr could drop the original case target constraint, leading to incorrect witness shrinking for nested sum-shaped values.
Changes:
- Preserve the original
casetarget type constraint when a prunedcaseis rebuilt asassertl/assertrduring the temporaryConstructDatarebuild. - Add a focused regression test that constructs the failing shape directly with
ConstructNodeand verifies pruning rewrites + witness preservation + execution equivalence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a pruning bug in RedeemNode::prune_with_tracker() that can corrupt nested sum-shaped witnesses when a case is pruned into assertl/assertr.
The issue was that after pruning a case into an assert, the temporary Construct DAG was retyped from the pruned structure alone. That drops the original case target constraint, which can let free target vars on the surviving branch collapse to 1. When final witness pruning runs, a live nested sum payload can then be incorrectly shrunk to unit.
The fix preserves the original case target when a pruned case is rebuilt as assertl/assertr, so witness shrinking continues to use the correct surviving type.
Tests
Adds a focused regression test that builds the failing shape directly with ConstructNode:
The regression reproduces the old witness-shrinking failure if this fix is reverted.