Skip to content

AB#44 Removing the serializable attribute from ValidationErrorCollection and ValidationError. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlaiseD merged 1 commit into from
Mar 4, 2026
Merged

AB#44 Removing the serializable attribute from ValidationErrorCollection and ValidationError. #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...cBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationError.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace LogicBuilder.Workflow.ComponentModel.Compiler
{
[Serializable()]
public sealed class ValidationError(string errorText, int errorNumber, bool isWarning, string propertyName)
{
private readonly string errorText = errorText;
Expand Down
1 change: 0 additions & 1 deletion ...orkflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationErrorCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace LogicBuilder.Workflow.ComponentModel.Compiler
{
[Serializable()]
public sealed class ValidationErrorCollection : Collection<ValidationError>
{
public ValidationErrorCollection()
Expand Down
6 changes: 3 additions & 3 deletions ...ow.ComponentModel.Serialization/LogicBuilder.Workflow.ComponentModel.Serialization.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<Description>Manages serialization of rule sets for .NetStandard.</Description>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
<PackageReleaseNotes>Refactoring to accelerate DevOps.</PackageReleaseNotes>
<PackageReleaseNotes>Fixes to improve maintainability and reliability.</PackageReleaseNotes>
<PackageTags>rules serialization</PackageTags>
<Copyright>Copyright © Microsoft 2017</Copyright>
<RepositoryUrl>https://github.com/BpsLogicBuilder/LogicBuilder.Workflow.ComponentModel.Serialization</RepositoryUrl>
Expand Down Expand Up @@ -44,12 +44,12 @@

<ItemGroup>
<PackageReference Include="LogicBuilder.ComponentModel.Design.Serialization" Version="2.0.9" />
<PackageReference Include="System.CodeDom" Version="10.0.2" />
<PackageReference Include="System.CodeDom" Version="10.0.3" />
<PackageReference Include="MinVer" Version="7.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.102" PrivateAssets="All" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.103" PrivateAssets="All" />
</ItemGroup>

<ItemGroup>
Expand Down
17 changes: 17 additions & 0 deletions ...mponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorCollectionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,5 +519,22 @@ public void AddRange_WithValidationErrorCollection_AddsAllItems()
}

#endregion

#region Serialization Tests

[Fact]
public void ValidationErrorCollection_DoesNotHaveSerializableAttribute()
{
// Arrange
var type = typeof(ValidationErrorCollection);

// Act
var attributes = type.GetCustomAttributes(typeof(SerializableAttribute), false);

// Assert
Assert.Empty(attributes);
}

#endregion
}
}
4 changes: 2 additions & 2 deletions Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ public void ToString_ReturnsExpectedFormat(int errorNumber, bool isWarning, stri
#region Serialization Tests

[Fact]
public void ValidationError_HasSerializableAttribute()
public void ValidationError_DoesNotHaveSerializableAttribute()
{
// Arrange
var type = typeof(ValidationError);
Expand All @@ -582,7 +582,7 @@ public void ValidationError_HasSerializableAttribute()
var attributes = type.GetCustomAttributes(typeof(SerializableAttribute), false);

// Assert
Assert.NotEmpty(attributes);
Assert.Empty(attributes);
}

#endregion
Expand Down
4 changes: 2 additions & 2 deletions ...low.ComponentModel.Serialization.Tests/Workflow.ComponentModel.Serialization.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'" />

<ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="6.0.4">
<PackageReference Include="coverlet.msbuild" Version="8.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit.v3" Version="3.2.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
Expand Down