Skip to content

Drafting lighting changes for REC working group#756

Merged
gtfierro merged 6 commits intomasterfrom
gtf-add-rec-lighting
Apr 22, 2026
Merged

Drafting lighting changes for REC working group#756
gtfierro merged 6 commits intomasterfrom
gtf-add-rec-lighting

Conversation

@gtfierro
Copy link
Copy Markdown
Member

@PeteHart and @erikoskarwallin here are the initial changes to brick as requested in the document from the lighting working group. Do you have any example/reference systems I could model?

@gtfierro gtfierro marked this pull request as draft January 30, 2026 22:31
@github-actions
Copy link
Copy Markdown

The latest build of the Brick ontology on this PR is available here.

Copy link
Copy Markdown
Member Author

@gtfierro gtfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeteHart and @erikoskarwallin we had some questions/comments on the proposed point classes. Can you take a look? Thanks!

Comment thread bricksrc/definitions.csv Outdated
Comment thread bricksrc/definitions.csv Outdated
@github-actions
Copy link
Copy Markdown

The latest build of the Brick ontology on this PR is available here.

@gtfierro gtfierro marked this pull request as ready for review February 19, 2026 16:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

The latest build of the Brick ontology on this PR is available here.

@github-actions
Copy link
Copy Markdown

The latest build of the Brick ontology on this PR is available here.

@github-actions
Copy link
Copy Markdown

The latest build of the Brick ontology on this PR is available here.

@gtfierro gtfierro merged commit ed00975 into master Apr 22, 2026
2 checks passed
@gtfierro gtfierro deleted the gtf-add-rec-lighting branch April 22, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants