TileKnowledge: Optimize GetTilesVisibleToUnit#889
Open
TomWerner wants to merge 1 commit intoDevelopmentfrom
Open
TileKnowledge: Optimize GetTilesVisibleToUnit#889TomWerner wants to merge 1 commit intoDevelopmentfrom
TomWerner wants to merge 1 commit intoDevelopmentfrom
Conversation
This speeds up the time for the first 100 turns in observer mode from ~40 seconds to ~35 on my chromebook, and brings the printf benchmark from ~250 ms to ~40.
stavrosfa
approved these changes
Feb 17, 2026
Contributor
stavrosfa
left a comment
stavrosfa
left a comment
There was a problem hiding this comment.
I run this and it seems to almost cut the calculation times in half from ~24ms to ~12ms on my machine, good stuff!
| // tiles away. We can't see the hill that is SW+SW of us | ||
| // because we are blocked. To implement this we need to | ||
| // prevent 90 degree "turns", which we handle by ensuring | ||
| // the a+b combo is never a combination of two N/S/E/W dirs. |
Contributor
There was a problem hiding this comment.
Can the a+b in the documentation be updated to reflect the renaming of the variables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up the time for the first 100 turns in observer mode from ~40 seconds to ~35 on my chromebook, and brings the printf benchmark from ~230 ms to ~40.
Optimizations:
TileDirection.GetValues(typeof(TileDirection))+ a dictionary lookup and just iterate over the dictionary directly