Correct SUV calculation in get_suv_constants#11
Open
carlvillads wants to merge 4 commits intomasterfrom
Open
Conversation
…int for multi-image PET series with fallback method
Contributor
|
Personligt vil jeg foretrække at funktionen giver en error hvis SeriesTime ikke eksisterer, frem for at defaulte til AcquisitionTime. Jeg frygter at det kan skabe nogle silent errors. SeriesTime bør altid eksistere for PET. |
Author
Giver god mening – jeg får lige lavet en ny commit |
Author
|
@ChristianHinge hvad siger du til denne ændring? ...
# Scan time
if time_tag == 'series':
acq_time = ds[0x0008,0x0031].value # Series time
elif time_tag == 'acquisition':
acq_time = ds.AcquisitionTime
else:
raise ValueError("'time_tag' must be 'series' or 'acquisition'")
...Har også dobbelttjekket selve tagget (for en sikkerheds skyld), og det burde være det korrekte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
get_suv_constantsinrhscripts/dcm.py.SUV-bw should be calculated from the SeriesTime DICOM tag instead of the AcquisitionTime tag
time_tagparameter toget_suv_constants, allowing to choose between using Series Time ((0008,0031)) or Acquisition Time ((0008,0032)) for time calculations, if Acquisition Time is still preferred.dcmreadwithstop_before_pixels=Truesince pixel data is not needed for header information