edssharp: add another extension for the EDS file for CountLabel#180
edssharp: add another extension for the EDS file for CountLabel#180ckhardin wants to merge 1 commit intoCANopenNode:mainfrom
Conversation
|
@nimrof - this might not be the patch if the actual expectation is that everything is supposed to be an xdd file and that is what is used to generate the CANopenNodeV4 export since the additional property support is in that it seems. without this - then we end up with the warnings in an EDS to CANopenNodeV4 - there might be other problems coming later as well - so, should this EDS to V4 just not be supported? or should it get fixes? And the real problem is that it does not build |
nimrof
left a comment
There was a problem hiding this comment.
Hi,
Thanks for the pr. I see the need and pr. looks good.
Just one little change i want and that is to check if there is a label before writing it to the file.
Sorry for the long review delay
1d5bbb7 to
8b2ff47
Compare
The count label is required to compile against the CANopenNode v4
library since the definitions are checked by code like the following
in CANopen.c
#if OD_CNT_NMT != 1
#error OD_CNT_NMT from OD.h not correct!
#endif
This problem is exhibited when there is no xpd file that has the
custom properties and there is only an EDS file available. The
StorageLocation is an example of setting the custom property for
the CO_storageGroup and this is adding a similar extension for
the CO_countLabel.
An example eds for NMT 0x1000 is shown below
[1000]
ParameterName=Device type
ObjectType=0x7
;CountLabel=NMT
;StorageLocation=ROM
DataType=0x0007
AccessType=ro
DefaultValue=0x00000000
PDOMapping=0
Signed-off-by: Charles Hardin <charles.hardin@redoxblox.com>
8b2ff47 to
7937b10
Compare
When I was integrating V4, i put all my efforts into xdd and tried to touch other in minimum. Xdd was meant to be a project file, eds only for export. But eds could also contain some custom properties and could also be used as a project file. I agree with the PR. Maybe there could be an option in exporter, similar as for xdd: export full eds or export stripped eds without custom properties. |
The count label is required to compile against the CANopenNode v4 library since the definitions are checked by code like the following in CANopen.c
This problem is exhibited when there is no xpd file that has the custom properties and there is only an EDS file available. The StorageLocation is an example of setting the custom property for the CO_storageGroup and this is adding a similar extension for the CO_countLabel.
An example eds for NMT 0x1000 is shown below