[MIX][FEAT] Suggested posix compatibility changes#197
[MIX][FEAT] Suggested posix compatibility changes#197reza0310 wants to merge 2 commits intoCANopenNode:mainfrom
Conversation
nimrof
left a comment
nimrof
left a comment
There was a problem hiding this comment.
Dont understand the need for the .sh files
Is that for development or normal use?
The nuget updates are very welcome
| </PackageReference> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" /> | ||
| <PackageReference Include="xunit.v3" Version="3.2.0" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" /> |
There was a problem hiding this comment.
this might be a good idea if it works in the CI and all we needed is included in the new nuget👍
There was a problem hiding this comment.
Looks like it is no building and there is only a problem with running the tests
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" /> | ||
| <PackageReference Include="xunit.v3" Version="3.2.0" /> |
There was a problem hiding this comment.
using xunit.v3 is a good idea, but we need to get it through the CI first to see if it works for all .net versions
It's for easier execution of the different modules from a shell. It is still just an idea I had tho I'm not sure if it's a good way to go or na. |
2 participants
Changed the tests' csprojs (for it to run as written in the xunit documentation).
Made a few scripts to use the CLI, GUI and run the tests in a shell.
I made those changes to enable
myselfany posix user to run our projects.I executed all of the scripts and they worked (even with args for the CLI one) without printing any unnecessary information.
Resolve #190 (just partially, merging this PR shouldn't close the issue)
I have read the contributing guidelines, I agree to following them and I agree to the Developer's Certificate of Origin 1.1.