fix: resolve TESSDATA_PREFIX path correctly for all Tesseract versions#2257
Open
DhanushVarma-2 wants to merge 1 commit intoCCExtractor:masterfrom
Open
fix: resolve TESSDATA_PREFIX path correctly for all Tesseract versions#2257DhanushVarma-2 wants to merge 1 commit intoCCExtractor:masterfrom
DhanushVarma-2 wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
DhanushVarma-2
force-pushed
the
fix/tessdata-path-2
branch
from
476f4c5 to
6906ef9
Compare
Two bugs in init_ocr() in ocr.c: 1. The Tesseract 4/5 branch always blindly appended '/tessdata' to the path returned by probe_tessdata_location(). If TESSDATA_PREFIX was already set to a path ending in 'tessdata/', this caused a double- append e.g. '/usr/share/tessdata/tessdata'. 2. The legacy Tesseract <4 branch passed tessdata_path raw to TessBaseAPIInit4 without appending 'tessdata' at all, causing Tesseract to look for eng.traineddata directly in e.g. '/usr/share/' instead of '/usr/share/tessdata/'. Fix: normalize the path once before both branches. Detect whether the returned path already ends with 'tessdata' or 'tessdata/', handle Windows backslash separators, and use the resolved path in both Tesseract version branches. Add mprint diagnostic for the resolved path. Fixes CCExtractor#1492
DhanushVarma-2
force-pushed
the
fix/tessdata-path-2
branch
from
6906ef9 to
71c5762
Compare
Contributor
Author
|
The format_rust CI failures are pre-existing on master . |
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 395f9b3...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 395f9b3...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two bugs in init_ocr():
The Tesseract 4/5 branch always appended /tessdata to the probed path — if TESSDATA_PREFIX was already set to point at the tessdata dir itself, this doubled it: /usr/share/tessdata/tessdata.
The legacy Tesseract <4 branch passed the raw probed path to TessBaseAPIInit4 with no /tessdata appended at all — so Tesseract looked for /usr/share/eng.traineddata instead of /usr/share/tessdata/eng.traineddata. This is the exact error in #1492.
Fix: build the tessdata path once before both branches — check if the path already ends with tessdata, otherwise append it. Windows backslash separators handled too. Both branches now use the same resolved path. Added an mprint line showing the resolved path to make future debugging easier.