Relax ShareDialog email validation regex#925
Open
vibhutomer wants to merge 2 commits intoCCExtractor:mainfrom
Open
Relax ShareDialog email validation regex#925vibhutomer wants to merge 2 commits intoCCExtractor:mainfrom
vibhutomer wants to merge 2 commits intoCCExtractor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a bug where the
ShareDialogemail validation strictly rejected valid email addresses containing hyphens or subdomains (e.g.,user@my-domain.comoruser@mail.university.edu).Proposed Changes
RegExpstring inlib/app/utils/share_dialog.dartto appropriately handle-and.characters within the domain grouping.google-services.jsonto bypass the Google Auth flow and reach the Share UI manually, I isolated and verified the regex logic locally via a standalone Dart script.Fixes #924
Screenshots
Checklist