Skip to content

Relax ShareDialog email validation regex#925

Open
vibhutomer wants to merge 2 commits intoCCExtractor:mainfrom
vibhutomer:fix-share-email-regex
Open

Relax ShareDialog email validation regex#925
vibhutomer wants to merge 2 commits intoCCExtractor:mainfrom
vibhutomer:fix-share-email-regex

Conversation

@vibhutomer
Copy link
Copy Markdown

Description

This PR addresses a bug where the ShareDialog email validation strictly rejected valid email addresses containing hyphens or subdomains (e.g., user@my-domain.com or user@mail.university.edu).

Proposed Changes

  • Updated the RegExp string in lib/app/utils/share_dialog.dart to appropriately handle - and . characters within the domain grouping.
  • Ensured users are no longer blocked from sharing alarms with standard workplace or university email addresses.
  • Note: As I lack the local Firebase google-services.json to bypass the Google Auth flow and reach the Share UI manually, I isolated and verified the regex logic locally via a standalone Dart script.

Fixes #924

Screenshots

Screenshot 2026-04-09 000941

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Share Alarm: Email validation regex rejects valid domains with hyphens or subdomains.

1 participant