Introduce Basic Orientational Entropy Calculations#294
Conversation
harryswift01
left a comment
There was a problem hiding this comment.
This addition to CodeEntropy is a major milestone in bringing new theory into the package, and this PR communicates that work very well. I’ve requested a few changes, but they are mainly focused on tidying up comments and clarifying certain areas. Functionally, this is looking very strong.
Since this introduces new entropy calculations, we should expect the regression test results to change. For that reason, I think it would be appropriate to re-run and update the baseline results to reflect the new calculation method. These can be updated locally with: pytest tests/regression --update-baselines. It also looks like coverage has dropped slightly. It would be great if we could bring that back up before merging.
We’re very close to getting this merged, thank you. If there’s anything I can do to help move this across the line, just let me know.
Summary
This pull request adds the basic orientational entropy calculation.
Changes
Adding Neighbours to Levels:
Orientational Entropy Calculation:
Conformational Entropy:
Documentation
Impact