Rr 139 error creating pool

[ryanraaschCDC]

No description provided.

[Copilot]

Pull request overview

This PR updates Azure Batch pool mount identity-reference handling to align with azure.mgmt.batch models (and pins the azure-mgmt-batch dependency version) in order to address an error encountered during pool creation.

Changes:

• Pin azure-mgmt-batch to >=18.0.0,<19.0.0.
• Update blob mount configuration generation to use azure.mgmt.batch.models and convert identity references to the mgmt-model type.
• Extend blob unit tests to assert the resulting identity reference is a mgmt-model ComputeNodeIdentityReference.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cfa/cloudops/blob.py	Switches mount configuration models to azure.mgmt.batch.models and adds conversion to mgmt identity-reference objects.
cfa/cloudops/auth.py	Changes compute_node_identity_reference to return a dict via as_dict().
tests/test_blob.py	Adds assertion that mount identity references are mgmt-model types.
pyproject.toml	Pins azure-mgmt-batch to <19.0.0.
cfa/cloudops/_cloudclient.py	Small control-flow change around node monitoring StartTask construction.

Comments suppressed due to low confidence (1)

cfa/cloudops/blob.py:300

• The parameter type for identity_references was widened to Any, but the function only supports a specific set of shapes (ComputeNodeIdentityReference, dict with resource_id, or resource_id string). Please replace Any with an explicit union type (and/or a small protocol) and update the parameter docstring accordingly so callers know what’s supported and type checkers can catch mistakes.

def get_node_mount_config(
    storage_containers: str | list[str],
    account_names: str | list[str],
    identity_references: Any,
    shared_relative_mount_path: str = "",
    mount_names: list[str] = None,
    blobfuse_options: str | list[str] = "",
    cache_blobfuse: bool = False,
    **kwargs,
) -> list[models.MountConfiguration]:

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.