Skip to content

Additional Error Handling#430

Merged
BradySkylight merged 14 commits intomainfrom
brady/214/error-handling
Apr 8, 2026
Merged

Additional Error Handling#430
BradySkylight merged 14 commits intomainfrom
brady/214/error-handling

Conversation

@BradySkylight
Copy link
Copy Markdown
Collaborator

@BradySkylight BradySkylight commented Apr 6, 2026

Description

With all the recent PRs merged it appears this ticket has been addressed. I searched for areas where exceptions are being picked up to ensure we are logging them and/or including the proper messages in various output objects. I also looked into TODOs. Errors seem to be well handled and messages are either being logged or passed down stream to other processes properly.

However, in my code grok I found some areas that could be cleaned up and asked some other questions. This PR only contains some of the clean-up of code and comments.

Related Issues

Closes #214

Additional Notes

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (2dfb427) to head (4c7f47a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   95.76%   95.75%   -0.01%     
==========================================
  Files          42       42              
  Lines        2220     2215       -5     
==========================================
- Hits         2126     2121       -5     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BradySkylight BradySkylight marked this pull request as ready for review April 7, 2026 15:34
Comment thread packages/augmentation/src/augmentation/services/eicr_augmenter.py
@BradySkylight BradySkylight changed the title Brady/214/error handling Additional Error Handling Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always love a code cleanup PR lol, nice and clean 😎

@BradySkylight BradySkylight merged commit 357044d into main Apr 8, 2026
5 checks passed
@BradySkylight BradySkylight deleted the brady/214/error-handling branch April 8, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eICR Processing Error Handling

4 participants